-
Notifications
You must be signed in to change notification settings - Fork 38
Add missing predicate actor.film in moredata/2 (issue 122) #124
Conversation
|
Thanks for your contribution. But as we gonna simplify the Schema. These changes aren't necessary. Please, if you still wanna contribute, you can do it by simplifying the Schema. e.g: |
|
Many thanks for the opportunity to contribute with this amazing project. it is something like this change done? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thank you!
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @MichaelJCompton)
|
@iuryfukuda are you using 1.1.0 or 1.1.1? |
|
I could not find the PR #4017 in v1.1.0. So I need to revert this commit :/ I should have checked this out before. My bad. see
https://github.com/dgraph-io/dgraph/releases/tag/v1.1.1 Please Open a PR for the right Branch. |
|
1.1.0, i don't see the version 1.1.1 listing with |
|
I mean, the version that you are using right now in your machine. Not the branch you're working on. |
|
ok, thank's, no problem, i work on this |
|
Oh, okay. The Branch for 1.1.1 doesn't exists at all. Get it. Sorry, I have to do more things about this. Cheers. |
|
no problems, i open the new PR #127 Cheers. |
) and simplifying the Type Schema" This reverts commit 5cfacbc.
More explicit is better.
Add the predicate
actor.filmin schema for better visualization of data.This change is
Tour Preview: