Skip to content
This repository was archived by the owner on Mar 29, 2025. It is now read-only.

Add missing predicate actor.film in moredata/2 (issue 122) #124

Merged
merged 2 commits into from
Feb 18, 2020
Merged

Add missing predicate actor.film in moredata/2 (issue 122) #124

merged 2 commits into from
Feb 18, 2020

Conversation

zbioe
Copy link
Contributor

@zbioe zbioe commented Feb 18, 2020

More explicit is better.
Add the predicate actor.film in schema for better visualization of data.


This change is Reviewable

Tour Preview: Dgraph Preview

@claassistantio
Copy link

claassistantio commented Feb 18, 2020

CLA assistant check
All committers have signed the CLA.

@zbioe zbioe changed the title Add missing predicate Add missing predicate actor.film in moredata/2 Feb 18, 2020
@zbioe zbioe changed the title Add missing predicate actor.film in moredata/2 Add missing predicate actor.film in moredata/2 (issue 122) Feb 18, 2020
@zbioe zbioe changed the base branch from master to dgraph-1.1.0 February 18, 2020 01:22
@MichelDiz
Copy link
Contributor

Thanks for your contribution.

But as we gonna simplify the Schema. These changes aren't necessary. Please, if you still wanna contribute, you can do it by simplifying the Schema. e.g:

type Person {
    name
    director.film
    actor.film
}

@zbioe
Copy link
Contributor Author

zbioe commented Feb 18, 2020

Many thanks for the opportunity to contribute with this amazing project.

it is something like this change done?

Copy link
Contributor

@MichelDiz MichelDiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you!

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MichaelJCompton)

@MichelDiz MichelDiz merged commit 5cfacbc into dgraph-io:dgraph-1.1.0 Feb 18, 2020
@MichelDiz
Copy link
Contributor

@iuryfukuda are you using 1.1.0 or 1.1.1?

@MichelDiz
Copy link
Contributor

MichelDiz commented Feb 18, 2020

I could not find the PR #4017 in v1.1.0. So I need to revert this commit :/
The right branch is v1.1.1

I should have checked this out before. My bad.

see

Simplify type definitions: type definitions no longer require the type (string, int, etc.) per field name. (#4017)

https://github.com/dgraph-io/dgraph/releases/tag/v1.1.1
and https://github.com/dgraph-io/dgraph/releases/tag/v1.1.0

Please Open a PR for the right Branch.

@zbioe
Copy link
Contributor Author

zbioe commented Feb 18, 2020

1.1.0, i don't see the version 1.1.1 listing with git branch -a:

$ git branch -a
* addMissingPredicate
  dgraph-1.1.0
  master
  remotes/origin/HEAD -> origin/master
  remotes/origin/addMissingPredicate
  remotes/origin/animesh2049/update-info
  remotes/origin/changeSchema
  remotes/origin/dgraph-1.0.16
  remotes/origin/dgraph-1.1.0
  remotes/origin/master
  remotes/origin/micheldiz/youtube
  remotes/origin/modifytuto
  remotes/origin/removeBadPredicates

@MichelDiz
Copy link
Contributor

I mean, the version that you are using right now in your machine. Not the branch you're working on.

@zbioe
Copy link
Contributor Author

zbioe commented Feb 18, 2020

ok, thank's, no problem, i work on this

@MichelDiz
Copy link
Contributor

Oh, okay. The Branch for 1.1.1 doesn't exists at all. Get it. Sorry, I have to do more things about this.
Please, create the PR for master.

Cheers.

@zbioe
Copy link
Contributor Author

zbioe commented Feb 18, 2020

no problems,

i open the new PR #127

Cheers.

MichelDiz added a commit that referenced this pull request Feb 18, 2020
) and simplifying the Type Schema"

This reverts commit 5cfacbc.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants