Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.1 changes and other minor changes #81

Closed
wants to merge 1 commit into from

Conversation

@prashant-shahi
Copy link
Member

commented Aug 1, 2019

  • changed uid to [uid]. #73
  • increased the maximum height of %expandable% block - resolving the partial visibility of query in /intro/4 #71
  • fixed previous page reference in markdowns
  • replaced capture_output with the native implementation for support of python<=3.7
multiple small changes
- changed uid to [uid].
- increased the maximum height of %expandable% block - resolving the partial visibility of query in /intro/4
- fixed previous page reference in markdowns
- replaced capture_output with the native implementation for support of python<=3.7

@prashant-shahi prashant-shahi requested review from paulftw and MichelDiz Aug 1, 2019

@prashant-shahi prashant-shahi requested a review from MichaelJCompton as a code owner Aug 1, 2019

@CLAassistant

This comment has been minimized.

Copy link

commented Aug 1, 2019

CLA assistant check
All committers have signed the CLA.

@prashant-shahi prashant-shahi changed the title Changed for v1.1 and minor other changes v1.1 changes and other minor changes Aug 1, 2019

director.film: uid @reverse .
genre: uid @reverse .
director.film: [uid] @reverse .
genre: [uid] @reverse .

This comment has been minimized.

Copy link
@MichelDiz

MichelDiz Aug 1, 2019

Member

Some of this is covered here https://github.com/dgraph-io/tutorial/pull/53/files Not sure if it's okay to overwrite tho.

This comment has been minimized.

Copy link
@prashant-shahi

prashant-shahi Aug 2, 2019

Author Member

Okay, I will be merging all the latest changes.

This comment has been minimized.

Copy link
@paulftw

paulftw Aug 2, 2019

Contributor

so what have you guys decided? are we changing schema in this PR or in 53?

@prashant-shahi

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2019

Some of the changes are covered and there seem to be quite a lot of changes done since then.

Let me find out what and all changes are needed from the current master and then send another PR.

@prashant-shahi prashant-shahi deleted the prashant/multiple-changes branch Aug 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.