Skip to content

David Greenspan
dgreensp

May 3, 2016
@dgreensp
Switch or match statement
Mar 30, 2016
dgreensp opened issue Riim/cellx#2
@dgreensp
Accessing any cell causes all change events to be fired?
Mar 30, 2016
Mar 15, 2016
dgreensp commented on pull request mooz/js2-mode#293
@dgreensp

I haven't had time to work on it lately.

Mar 8, 2016
dgreensp commented on pull request eslint/eslint#5509
@dgreensp

Woot!! Thanks guys!

Mar 7, 2016
dgreensp commented on pull request eslint/eslint#5509
@dgreensp

@BYK I don't think there's anything controversial here. All the existing tests pass except one -- so people still get their hanging brackets, etc. …

Mar 7, 2016
dgreensp commented on issue eslint/eslint#5492
@dgreensp

Ok, I have a PR ready for review: #5509

Mar 7, 2016
@dgreensp
  • @dgreensp ad100fd
    Fix: overindent in VariableDeclarator parens or brackets (fixes #5492)
Mar 7, 2016
dgreensp opened pull request eslint/eslint#5509
@dgreensp
Fix overindent in VariableDeclarator parens or brackets (fixes #5492)
1 commit with 22 additions and 4 deletions
Mar 7, 2016
@dgreensp
  • @dgreensp a4529ad
    Fix overindent in VariableDeclarator parens or brackets (fixes #5492)
Mar 7, 2016
Mar 7, 2016
@dgreensp
Mar 7, 2016
dgreensp commented on issue eslint/eslint#5492
@dgreensp

I don't think that's exactly right; you still want: const foo = 1, bar = [ 2 ]; The offending logic seems to be: https://github.com/eslint/eslint/…

Mar 7, 2016
dgreensp commented on issue eslint/eslint#5492
@dgreensp

I've been grappling with this problem over the past week, including with ESLint 2.3.0. It "fixes" this code with excessive indentation: it('displa…

Feb 22, 2016
Feb 19, 2016
dgreensp opened pull request benjamn/recast#259
@dgreensp
Print trailing comments on statements as trailing
1 commit with 39 additions and 1 deletion
Feb 19, 2016
@dgreensp
Trailing block comments printed before node?
Feb 19, 2016
@dgreensp
Feb 19, 2016
@dgreensp
  • @benjamn 6b912c1
    Bump NPM version to 0.11.1 in preparation for publishing.
  • @benjamn 88d6be9
    Merge pull request #258 from dgreensp/dgreensp-trailing-comments
  • 1 more commit »
Feb 18, 2016
dgreensp opened pull request benjamn/recast#258
@dgreensp
Support babylon's CommentBlock, CommentLine types
1 commit with 4 additions and 3 deletions
Feb 18, 2016
@dgreensp
  • @dgreensp 02bcbf6
    Support babylon's CommentBlock, CommentLine types
Feb 18, 2016
Feb 18, 2016
Feb 18, 2016
dgreensp commented on issue benjamn/recast#191
@dgreensp

I wonder if there's a simple scheme that works for the case where a single-line comment is on a line by itself. We have an eslint rule in force tha…

Feb 18, 2016
dgreensp commented on issue benjamn/recast#257
@dgreensp

It's caused by a typo; "Block" should be "CommentBlock". Shall I prepare a PR?

Feb 17, 2016
dgreensp commented on issue benjamn/recast#257
@dgreensp

In that issue, though, block comments don't move.

Feb 16, 2016
dgreensp commented on issue benjamn/recast#257
@dgreensp

Oh, I totally misread that code; printComments is actually supposed to print the path itself in the middle. I'll look again at what's happening.

Feb 16, 2016
@dgreensp
Trailing block comments printed before node?
Feb 15, 2016
dgreensp opened pull request facebook/jscodeshift#88
@dgreensp
Fix time elapsed display
1 commit with 2 additions and 3 deletions
Something went wrong with that request. Please try again.