Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Show “Not Responding” in Home app when Ring API is inaccessible #413

Closed
smockle opened this issue Jul 22, 2020 · 2 comments
Closed
Labels
enhancement New feature or request
Projects

Comments

@smockle
Copy link
Sponsor Collaborator

smockle commented Jul 22, 2020

Feature Request

Description

The following error was logged:

7/21/2020, 4:00:47 PM] [Ring] Failed to reach Ring server at https://oauth.ring.com/oauth/token.  getaddrinfo ENOTFOUND oauth.ring.com.  Trying again in 5 seconds...
[7/21/2020, 4:02:05 PM] [Ring] Request to https://app.ring.com/rhq/v1/devices/v1/locations failed with status undefined. Response body: undefined
[7/21/2020, 4:02:05 PM] [Ring] Error connecting to API
[7/21/2020, 4:02:05 PM] [Ring] Error: Refresh token is not valid.  Unable to authenticate with Ring servers.  See https://github.com/dgreif/ring/wiki/Refresh-Tokens
    at RingRestClient.getGrantData (/Users/clay/.config/yarn/global/node_modules/homebridge-ring/lib/api/rest-client.js:116:15)
    at RingRestClient.<anonymous> (/Users/clay/.config/yarn/global/node_modules/homebridge-ring/lib/api/rest-client.js:120:36)
    at Generator.next (<anonymous>)
    at /Users/clay/.config/yarn/global/node_modules/homebridge-ring/lib/api/rest-client.js:27:71
    at new Promise (<anonymous>)
    at __awaiter (/Users/clay/.config/yarn/global/node_modules/homebridge-ring/lib/api/rest-client.js:23:12)
    at RingRestClient.getAuth (/Users/clay/.config/yarn/global/node_modules/homebridge-ring/lib/api/rest-client.js:119:16)
    at RingRestClient.<anonymous> (/Users/clay/.config/yarn/global/node_modules/homebridge-ring/lib/api/rest-client.js:143:33)
    at Generator.throw (<anonymous>)
    at rejected (/Users/clay/.config/yarn/global/node_modules/homebridge-ring/lib/api/rest-client.js:25:65)

The error itself is unremarkable—it’s probably an instance of #373, #374, or #397. I obtained a new refresh token and updated homebridge-ring, and things are working fine now.

But the incident made me realize something: Although Homebridge Ring was experiencing a fatal error, there was no indication anything was wrong in the Home app. All devices continued to show their last known states. When I repeatedly tapped a light in the Home app, the UI toggled between the “100%” (on) and “Off” states as if everything was working fine. But devices in my house were not actually being controlled, because Homebridge Ring couldn’t connect to the Ring API.

Describe the solution you'd like

Several hours passed before I noticed the issue. I think it would be nice if–when Homebridge Ring is unable to connect to the Ring API–the plugin’s accessories showed “Not Responding” in the Home app, so fatal errors like this one are more obvious.

Describe alternatives you've considered

I’m not sure which error messages are supported by the Home app. It’s possible there is a more specific/clear message than “Not Responding”. (Update 2020-11-20: From homebridge/HAP-NodeJS#556, I found a list of supported statuses. SERVICE_COMMUNICATION_FAILURE seems to be the most appropriate.)

I have a few ideas about how the error which precipitated this could be approached (and, if I recall correctly, this has been discussed at length previously, in the aforementioned issues #373, #374, or #397 and elsewhere), but I’d like to scope discussion in this issue to error messages in the Home app.

@smockle smockle added the enhancement New feature or request label Jul 22, 2020
@smockle smockle changed the title Proposal: Show “Not Responding” in Home app when refresh token is not valid Proposal: Show “Not Responding” in Home app when API is inaccessible Jul 22, 2020
@smockle smockle changed the title Proposal: Show “Not Responding” in Home app when API is inaccessible Proposal: Show “Not Responding” in Home app when Ring API is inaccessible Jul 22, 2020
@dgreif
Copy link
Owner

dgreif commented Jul 23, 2020

Thanks for the idea @smockle. I'll look into it

@dgreif dgreif added this to Low priority in Ring Feb 21, 2021
@dgreif
Copy link
Owner

dgreif commented Aug 27, 2022

Haven't gotten around to this in a few years, and it doesn't look like there has been more requests for it. Thanks for the suggestion @smockle!

@dgreif dgreif closed this as not planned Won't fix, can't repro, duplicate, stale Aug 27, 2022
Ring automation moved this from Low priority to Closed Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Ring
Closed
Development

No branches or pull requests

2 participants