Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some property macros do not use $crate:: access #234

Closed
HeroicKatora opened this issue Jun 18, 2020 · 1 comment · Fixed by #235
Closed

Some property macros do not use $crate:: access #234

HeroicKatora opened this issue Jun 18, 2020 · 1 comment · Fixed by #235

Comments

@HeroicKatora
Copy link

This issue affects code that declares classes with properties through py_class!/@property. In slots.rs some of the macros use bare names instead of $crate::_ when using others. This makes it necessary to manually import the referred to names on use. In particular, there are bare uses of py_class_prop_getter, py_class_prop_setter, py_class_call_slot_impl_with_ref and potentially others.

markbt added a commit to markbt/rust-cpython that referenced this issue Jun 18, 2020
Some macro definitions are missing `$crate::` in their calls to other macros.  Add them.

Fixes dgrunwald#234
@markbt
Copy link
Collaborator

markbt commented Jun 18, 2020

Thanks for the report! I've created #235 to fix them. I think I got them all, but let me know if you find any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants