Add a matrix composition method. #14

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

Dan ... please consider this change for folks wanting a short-cut form for matrix composition up to 5 deep. 5 deep is somewhat arbitrary here ... but as you know ... I'm looking for some helpful hints and trying to learn about TYPE and spec.

Shoot me a hint here and all make it better. I had a translate, three rotates and a translate back composition. Add a scale there and would have 6 in composition stack.

More than anything else ... I just wanted to try and use the ::e3d_matrix( ) specifier and wasn't sure it I could put that in a list. It looked like it need to be a whole arg ... not a pattern in an arg.

Owner

dgud commented May 6, 2011

I have made another module e3d_translate I would like to see it in there instead,
so can you repost when this patch on that module later when I have commited that one,
but I can not get that branch working so it will take a while until I have everything fixed.

ggaliens commented May 6, 2011

Bit of a misnomer isn't it ? Composition might have rotation, scaling, and other things rolled into it. So putting it under a heading of translate will at very least be misleading to the reader.

Why "translate" ? I believe naming is very important. I thought e3d_mat was a nice well defined BOX ... maybe I didn't see what all was in there. Please help me to understand.

WHAT ABOUT : e3d_transform ?

If English is your second language ... I'm going to say you just mad a boo-boo with name choice.

I'm going to have a look at what you put in e3d_transform since that's what I think you meant (vs e3d_translate).
I really want to try and get this matrix request done and closed as per your wishes ... so let's keep this one open and on our radars ? It means a lot to me since I have done a bunch of my own plugin refactors based on this one. I could like w/o it ... but it would be much more fun to live with it. I see you are actively looking over the pull requests.

And thanks for your consideration and all you do for Wings3D.

What I wrote as mul_fold might be better named as mul_many or something ... list a list of matricies to be composited.
That's what I wanted by the changes I had pending. I hope I didn't mis the boat because I waited for your reply, no matter how stupid that was on my part.

I just intended to be a covienent way to composite matrices into a final one w/o intermediate functions call. Just a list of matricies to be composited and done for you. That's all I need. Don't care what it's called. But I was hoping to get it into e3d_mat and now ... e3d_transform as per you wished.

Is there still time ? It looks like you are doing something with installers ?

Owner

dgud commented Nov 13, 2011

Those changes needs to be based on my branch, which isn't in master yet.

So you will have to be patient.

/Dan

On Sun, Nov 13, 2011 at 7:50 PM, Mark
reply@reply.github.com
wrote:

What I wrote as mul_fold might be better named as mul_many or something ... list a list of matricies to be composited.
That's what I wanted by the changes I had pending.  I hope I didn't mis the boat because I waited for your reply, no matter how stupid that was on my part.

I just intended to be a covienent way to composite matrices into a final one w/o intermediate functions call.  Just a list of matricies to be composited and done for you. That's all I need.  Don't care what it's called. But I was hoping to get it into e3d_mat and now ... e3d_transform as per you wished.

Is there still time ?  It looks like you are doing something with installers ?


Reply to this email directly or view it on GitHub:
#14 (comment)

@dgud dgud closed this Jan 9, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment