Ggaliens/centroid by volume #9

Closed
wants to merge 3 commits into from

2 participants

@ggaliens

OK. This is updated centroids pull request on same branch. Spacing addressed.
link provided.

@ggaliens

I didn't mean for the other comments to disappear. What I did was re-pull my original branch down. Maybe I did more than that. Anyway ... I'm still learning GIT process.

@ggaliens

OK ... a bit more fussing around. I really should be in bed.
I wanted to make sure to treat / add volume as discrete method at same time as adding centroid since they are so strongly related. I also notice that my prior commit of centroid was not optimized as it still played with Area the same way Scorpius had his function which was called area_volume. For centroid, area was just ignored ... so for optimizations sake ... I thought it very proactive to get rid of the area expressions since they were effectively code-lint.

@ggaliens

B.T.W. If a manifold has negative volume ... it is inside out. Pretty cool/basic use of volume.

@ggaliens

Dan ... Hope you see this I'm needing to catch a bad arith when volume is ZERO and use fallback scheme.
This is needed for centroid of "FLAT OBJECTS" with zero volume, and oddball case ... but I ran into it. So added the
protection.

@dgud
Owner

Merged

@dgud dgud closed this Jan 9, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment