I have run into cases where (buffer-file-name buf) returned nil but the preceding conditions where non-nil. This happens in buffers created with magit-find-file. I am not sure where diff-hl gets turned on in those files and whether that is desirable or not.

I'll investigate some other time but thought I would let you know. Meanwhile you might wanna add an additional condition (buffer-file-name buf).