New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new `Some` and `None` constructors #9

Merged
merged 1 commit into from Sep 10, 2018

Conversation

Projects
None yet
2 participants
@Gabriel439
Contributor

Gabriel439 commented Sep 7, 2018

This also removes ./Optional/{Some,None} since they are now obsolete

This also reformats all the files, which is why there are some unrelated changes

I've made the matching changes to dhall-lang/dhall-haskell#559
to verify that the updated examples are correct

Gabriel Gonzalez
Use new `Some` and `None` constructors
This also removes `./Optional/{Some,None}` since they are now obsolete
@f-f

This comment has been minimized.

Show comment
Hide comment
@f-f

f-f Sep 7, 2018

Member

@Gabriel439 should we add this repo as submodule of dhall-haskell?
It would avoid the whole two-copies-of-prelude-go-out-of-sync issue in the future.

Member

f-f commented Sep 7, 2018

@Gabriel439 should we add this repo as submodule of dhall-haskell?
It would avoid the whole two-copies-of-prelude-go-out-of-sync issue in the future.

@f-f

f-f approved these changes Sep 7, 2018

This is great, Some/None make things quite more readable 👏

@Gabriel439

This comment has been minimized.

Show comment
Hide comment
@Gabriel439

Gabriel439 Sep 7, 2018

Contributor

@f-f: Yes, we should. I'm going to do that after merging the corresponding Haskell pull request

Contributor

Gabriel439 commented Sep 7, 2018

@f-f: Yes, we should. I'm going to do that after merging the corresponding Haskell pull request

@Gabriel439 Gabriel439 merged commit 0c83aed into master Sep 10, 2018

@Gabriel439 Gabriel439 deleted the gabriel/some_none branch Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment