Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upError reporting for list element types happens after substitution #230
Comments
This comment has been minimized.
This comment has been minimized.
|
Yeah, the only reason that this line of the error message is displayed at all:
... is because I had not yet improved Dhall's error messages for lists to narrow the source span to the offending list element. What I propose is fixing the source span so that the error message becomes:
Would that work for you? |
This comment has been minimized.
This comment has been minimized.
|
Sure, that looks good to me
…On 27 Jan 2018 4:40 pm, "Gabriel Gonzalez" ***@***.***> wrote:
Yeah, the only reason that this line of the error message is displayed at
all:
↳ (λ(package : Text) → λ(min : List ...
... is because I had not yet improved Dhall's error messages for lists to
narrow the source span to the offending list element. What I propose is
fixing the source span so that the error message becomes:
Your first ❰List❱ element has this type:
↳ { bounds : VersionRange, package : Text }
... but the following element at index 18 has this type instead:
↳ ∀(max : List Natural) → { bounds : VersionRange, package : Text }
...
bounded "text-format" [ +0, +4 ]
Would that work for you?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#230 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABRjr5fq66f10L7WvcQQ6LFhB9zpM7Fks5tO1FwgaJpZM4RqVv3>
.
|
Gabriel439
added a commit
that referenced
this issue
Jan 28, 2018
Gabriel439
referenced this issue
Jan 28, 2018
Merged
Improve error messages for list elements with the wrong type #236
Gabriel439
closed this
in
#236
Jan 28, 2018
Gabriel439
added a commit
that referenced
this issue
Jan 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ocharles commentedJan 23, 2018
Apologies for the brevity but let me just vomit out my current context. We have this in a Dhall file:
build-dependenciesgoes on for a whileYet when I type check this:
The 18th element is just some function application though: