Skip to content

/dhall-haskell

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new conversion primitives #49

Closed
Gabriel439 opened this issue May 7, 2017 · 1 comment

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Gabriel439
@Gabriel439
Copy link
Collaborator

commented May 7, 2017 •
edited by markus1189

As mentioned in #47, we need the following new builtin functions in order to render numeric values:

  • Natural/show : Natural → Text
  • Integer/show : Integer → Text
  • Double/show : Double → Text
  • Natural/toInteger : Natural → Integer

The show functions should render in the exact same format that Dhall parses to source code. The purpose of the Natural/toInteger function is to help render Natural numbers without a leading + by converting them to Integers first

markus1189 added a commit that referenced this issue May 8, 2017

@markus1189
Implement Natural/toInteger as primitive conversion 
Relates to #49
Loading status checks…
89037eb

@markus1189 markus1189 referenced this issue May 8, 2017

Merged

Implement Natural/toInteger #50

Gabriel439 added a commit that referenced this issue May 8, 2017

@markus1189 @Gabriel439
Implement Natural/toInteger (#50) 
* Move test utils into separate module and use custom assertions

* Implement Natural/toInteger as primitive conversion

Relates to #49
Loading status checks…
a40cd7c

@markus1189 markus1189 referenced this issue May 8, 2017

Merged

Implement Natural/show #52

markus1189 added a commit that referenced this issue May 8, 2017

@markus1189
Implement Integer/show 
Relates to #49
Loading status checks…
af797ea

markus1189 added a commit that referenced this issue May 9, 2017

@markus1189
Implement Integer/show 
Relates to #49
Loading status checks…
861c5ca

@markus1189 markus1189 referenced this issue May 9, 2017

Closed

Implement Integer/show #53

markus1189 added a commit that referenced this issue May 9, 2017

@markus1189
Implement Double/show 
Relates to #49
Loading status checks…
a661632

@markus1189 markus1189 referenced this issue May 9, 2017

Merged

Implement Double/show and Integer/show #54

Gabriel439 added a commit that referenced this issue May 9, 2017

@markus1189 @Gabriel439
Implement Double/show and Integer/show (#54) 
* Implement Integer/show

Relates to #49

* Implement Double/show

Relates to #49
Loading status checks…
05e7fff
@Gabriel439

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

commented May 11, 2017

All four conversion primitives are done now, so I'll mark this resolved

@Gabriel439 Gabriel439 closed this May 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.