Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement Inject instance for unnamed tuples. #107
Conversation
bosu
added some commits
Aug 23, 2017
This comment has been minimized.
This comment has been minimized.
|
Actually, you don't need deriving instance (Interpret a, Interpret b) => Interpret (a, b)
deriving instance (Inject a, Inject b) => Inject (a, b)If you do that then you delete everything |
This comment has been minimized.
This comment has been minimized.
|
Done. |
This comment has been minimized.
This comment has been minimized.
|
Awesome! Thanks for doing this :) |
Gabriel439
merged commit 5b1cbb0
into
dhall-lang:master
Aug 26, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
bosu
deleted the
bosu:unnamed-inject
branch
Aug 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
bosu commentedAug 23, 2017
Implementation is similar to #103.
Last patch in the series shows that
R2is necessary: generic instance is not being picked up for tuples.