New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Inject instance for unnamed tuples. #107

Merged
merged 4 commits into from Aug 26, 2017

Conversation

Projects
None yet
2 participants
@bosu
Collaborator

bosu commented Aug 23, 2017

Implementation is similar to #103.

Last patch in the series shows that R2 is necessary: generic instance is not being picked up for tuples.

@Gabriel439

This comment has been minimized.

Show comment
Hide comment
@Gabriel439

Gabriel439 Aug 26, 2017

Collaborator

Actually, you don't need R2 if you enable the StandaloneDeriving extension. Then you can simplify the two instances for tuples to:

deriving instance (Interpret a, Interpret b) => Interpret (a, b)

deriving instance (Inject a, Inject b) => Inject (a, b)

If you do that then you delete everything R2-related

Collaborator

Gabriel439 commented Aug 26, 2017

Actually, you don't need R2 if you enable the StandaloneDeriving extension. Then you can simplify the two instances for tuples to:

deriving instance (Interpret a, Interpret b) => Interpret (a, b)

deriving instance (Inject a, Inject b) => Inject (a, b)

If you do that then you delete everything R2-related

@bosu

This comment has been minimized.

Show comment
Hide comment
@bosu

bosu Aug 26, 2017

Collaborator

Done.

Collaborator

bosu commented Aug 26, 2017

Done.

@Gabriel439

This comment has been minimized.

Show comment
Hide comment
@Gabriel439

Gabriel439 Aug 26, 2017

Collaborator

Awesome! Thanks for doing this :)

Collaborator

Gabriel439 commented Aug 26, 2017

Awesome! Thanks for doing this :)

@Gabriel439 Gabriel439 merged commit 5b1cbb0 into dhall-lang:master Aug 26, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bosu bosu deleted the bosu:unnamed-inject branch Aug 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment