Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dhall format] Prefer unquoted URLs #1235

Merged
merged 4 commits into from Aug 22, 2019

Conversation

@philandstuff
Copy link
Contributor

philandstuff commented Aug 13, 2019

This updates dhall format to prefer unquoted URLs.

I included the test cases described in #1109, but along the way I
discovered a standard bug so I have opened dhall-lang/dhall-lang#704 to
fix it. This change depends on that upstream fix.

Fixes #1109.

This updates `dhall format` to prefer unquoted URLs.

I included the test cases described in #1109, but along the way I
discovered a standard bug so I have opened dhall-lang/dhall-lang#704 to
fix it.  This change depends on that upstream fix.

Fixes #1109.
@Gabriel439

This comment has been minimized.

Copy link
Collaborator

Gabriel439 commented Aug 21, 2019

@philandstuff: Feel free to skip newly-added test cases that we haven't addressed yet

@philandstuff philandstuff force-pushed the philandstuff:format-urls-as-unquoted branch 2 times, most recently from 940d4f5 to 2c0920d Aug 22, 2019
@Gabriel439 Gabriel439 added the merge me label Aug 22, 2019
@mergify mergify bot merged commit 06dc9ab into dhall-lang:master Aug 22, 2019
4 checks passed
4 checks passed
Summary 2 rules match
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hydra Hydra build #29378 of dhall-haskell:1235:dhall
Details
@philandstuff philandstuff deleted the philandstuff:format-urls-as-unquoted branch Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.