Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix unbound variable bug #134
Conversation
bosu
reviewed
Sep 13, 2017
tests/Regression.hs
Outdated
| -- | ||
| -- This bug was originally reported in issue #10 | ||
| _ <- Util.code "let Day : Type = Natural in λ(x : Day) → x" | ||
| return () |
This comment has been minimized.
This comment has been minimized.
bosu
Sep 13, 2017
Collaborator
There is a parenthesis missing here (from line 89). This is the cause for Travis build check.
+1 on the fix itself, of course.
This comment has been minimized.
This comment has been minimized.
|
Whoops! You can tell I was in a hurry and couldn't run tests locally this morning :) |
bosu
merged commit 6bbff51
into
master
Sep 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Gabriel439 commentedSep 13, 2017
Related to #10
When type-checking the following expression:
... Dhall had a bug where it would add
Day : Typeto the context wheninferring the type of
λ(a : Day) → x(which is∀(x : Day) → Day), butDaywas missing from the context when inferring the kind of
∀(x : Day) → Day,leading to an unbound variable error
This change fixes the bug and adds a regression test to prevent the bug from
recurring