Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix type-checking bugs in `let` #136
Conversation
bosu
merged commit 8a4e744
into
master
Sep 16, 2017
Gabriel439
deleted the
gabriel/typecheck_let
branch
Jan 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Gabriel439 commentedSep 15, 2017
Fixes #135
Dhall requires that a
letexpression of the form:... should behave the same as the following equivalent lambda expression:
... meaning that if one type-checks then the other should type-check and (vice
versa) if one does not type-check then the other should not type-check. The
only difference should be either:
let-specific)I used equational reasoning to discover two corner cases where the two
expressions diverged in their type-checking behavior. This change fixes that
and includes two regression tests to capture the two corner cases to prevent
this problem from recurring