Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp dhall-lang.org #1526

Merged
merged 16 commits into from Nov 13, 2019
Merged

Revamp dhall-lang.org #1526

merged 16 commits into from Nov 13, 2019

Conversation

@Gabriel439
Copy link
Collaborator

Gabriel439 commented Nov 10, 2019

The main changes are:

The main changes are:

* Rework the text substantially to match [the new
  "pitch"](https://discourse.dhall-lang.org/t/more-brainstorming-for-changing-the-dhall-lang-org-landing-page/101/18)
* Add a new "Hash" tab to the live demo
* Use the [new logo](dhall-lang/dhall-lang#803)
@Gabriel439

This comment has been minimized.

Copy link
Collaborator Author

Gabriel439 commented Nov 10, 2019

Here is a GIF you can use for reference (Edit: updated to most recent version):

website

... and you can download a tarball for the latest website built from this pull request using the following link:

https://hydra.dhall-lang.org/job/dhall-haskell/1526/tarball-website/latest/download-by-type/file/binary-dist

Copy link
Collaborator

sjakobi left a comment

Good stuff! 👍

dhall-try/index.html Show resolved Hide resolved
dhall-try/index.html Show resolved Hide resolved
<a href="https://github.com/dhall-lang/dhall-lang/wiki/Programmable-configuration-files"class="btn btn-lg btn-outline-dark bg-light">Learn More <i class="fas fa-book"></i></a>
<h1 class="display-4">Don't repeat yourself</h1>
<hr class="my-4">
<p class="lead">Struggling with configuration drift? Create a <a href="https://en.wikipedia.org/wiki/Single_source_of_truth">single source of truth</a> you can reference everywhere.</p>

This comment has been minimized.

Copy link
@sjakobi

sjakobi Nov 10, 2019

Collaborator

I hadn't heard the term "configuration drift" before, although I can roughly imagine what it means. Would

Struggling with inconsistent configuration?

capture the same idea?

This comment has been minimized.

Copy link
@Gabriel439

Gabriel439 Nov 10, 2019

Author Collaborator

It's a pretty common term in the DevOps world, but I could link "configuration drift" to a definition like this one:

https://kemptechnologies.com/glossary/configuration-drift/

... or even quote the definition of configuration drift inline within the same section:

Configuration drift occurs when a standardized group of IT resources, be they virtual servers, standard router configurations in VNF deployments, or any other deployment group that is built from a standard template, diverge in configuration over time. As administrators make changes to one resource that isn’t made to another in the same group, or if a new service is installed on some of them, then configurations can drift. Configuration drift can make it very hard to manage IT systems over time. The Infrastructure as Code methodology from DevOps is designed to combat Configuration Drift and other infrastructure management problems.

dhall-try/index.html Outdated Show resolved Hide resolved
dhall-try/index.html Outdated Show resolved Hide resolved
dhall-try/index.html Outdated Show resolved Hide resolved
Gabriel439 and others added 2 commits Nov 10, 2019
... as suggested by @sjakobi

Co-Authored-By: Simon Jakobi <simon.jakobi@gmail.com>
... as suggested by @sjakobi

Co-Authored-By: Simon Jakobi <simon.jakobi@gmail.com>
dhall-try/index.html Outdated Show resolved Hide resolved
Gabriel439 added 2 commits Nov 10, 2019
…haskell into gabriel/revamp_website
dhall-try/index.html Outdated Show resolved Hide resolved
dhall-try/index.html Outdated Show resolved Hide resolved
dhall-try/index.html Outdated Show resolved Hide resolved
Gabriel439 added 2 commits Nov 11, 2019
... based on feedback from @sjakobi and @joneshf
... based on feedback from @sjakobi
Copy link
Collaborator

sjakobi left a comment

Cheers! 👍

dhall-try/index.html Outdated Show resolved Hide resolved
s/in/on/
... as suggested by @sjakobi

Co-Authored-By: Simon Jakobi <simon.jakobi@gmail.com>
@SiriusStarr

This comment has been minimized.

Copy link
Collaborator

SiriusStarr commented Nov 11, 2019

Not a regression, but the dropdown menus are still out of (vertical) alignment with the social badges/button around them (Firefox and Chromium on Linux).
Screenshot_2019-11-11 The Dhall configuration language

As far as the new content, the editor support picture is behaving weirdly in Chromium on Linux; you can catch a brief flash of the image if you refresh and then it disappears. Maybe something weird about my system, but someone else in Chromium should check.
2019-11-11_10-35
The editor integration picture works fine in Firefox, but I personally don't love the color theme.
Screenshot_2019-11-11 The Dhall configuration language 2
The whole thing has a kind of sickly yellow hue that looks very out of place next to the clean background and button (in addition to just being somewhat hard to read contrast-wise).

Both the "Safety Guarantees" and header and final "Get Started" buttons are capitalized in that form, but the rest of the site (and the other buttons) are written only with the first word capitalized, e.g. "Supported integrations". They should presumably all use the same capitalization format.

The last subheading (under "Use programming language features") reads: "Hold your configuration files to the same standard of quality as the rest of your code " and is missing a final period, unlike all of the other subheadings.

Should the Twitter quotes on the last section be brought into a single line, so there's less dead space? It looks like they'd fit.
Screenshot_2019-11-11 The Dhall configuration language3
The editor integration picture also leaves quite a lot of dead space to the right side.

@SiriusStarr

This comment has been minimized.

Copy link
Collaborator

SiriusStarr commented Nov 11, 2019

Correction RE the editor integration picture on Chromium: It looks like only the first frame shows up and then it turns transparent for the rest of them, until it loops and the first frame shows up again (before once more disappearing).

@arianvp

This comment has been minimized.

Copy link
Member

arianvp commented Nov 11, 2019

why / when did we change the logo? I liked the old one a lot

Edit: I see you linked to the PR

@Gabriel439

This comment has been minimized.

Copy link
Collaborator Author

Gabriel439 commented Nov 12, 2019

@SiriusStarr: I can reproduce with Chromium on Linux and I see the following logs:

libpng warning: size in first frame's fcTL must match the size in IHDR
libpng warning: Skipped (ignored) a chunk between APNG chunks
libpng warning: Skipped (ignored) a chunk between APNG chunks
libpng warning: Skipped (ignored) a chunk between APNG chunks

I'm going to try to create a new GIF of editor support

Gabriel439 added 4 commits Nov 12, 2019
... this fixes the Chromium issues and also the contrast issues reported
by @SiriusStarr
... as suggested by @SiriusStarr
@SiriusStarr

This comment has been minimized.

Copy link
Collaborator

SiriusStarr commented Nov 12, 2019

@Gabriel439 LGTM. Sorry for the dump of things last time. XD

@Gabriel439

This comment has been minimized.

Copy link
Collaborator Author

Gabriel439 commented Nov 12, 2019

@SiriusStarr: No problem at all! 🙂

I'll wait one more day for feedback and then merge if nobody requests anything new

Gabriel439 added 2 commits Nov 12, 2019
@PierreR

This comment has been minimized.

Copy link
Contributor

PierreR commented Nov 13, 2019

Just in case I am not the only one in that boat, I am not convinced by the background colors (particularly green)
I am not sure this is the kind of look that appeals to managers/sales ... but hell why not ;-)

@Gabriel439

This comment has been minimized.

Copy link
Collaborator Author

Gabriel439 commented Nov 13, 2019

@PierreR: Right now I'm mainly focused on content. I will do a separate pass later to make the page more visually appealing

@Gabriel439 Gabriel439 merged commit 39aaa86 into master Nov 13, 2019
4 checks passed
4 checks passed
Summary 1 rule matches and 1 potential rule
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hydra Hydra build #44352 of dhall-haskell:1526:dhall
Details
@Gabriel439 Gabriel439 deleted the gabriel/revamp_website branch Nov 13, 2019
@anttih

This comment has been minimized.

Copy link

anttih commented Nov 22, 2019

dhall-lang.org still displays the old content. Is this intentional?

@Gabriel439

This comment has been minimized.

Copy link
Collaborator Author

Gabriel439 commented Nov 22, 2019

@anttih: It's a mistake on my part. I deployed the newer dhall-lang.org content off of this branch: dhall-lang/dhall-lang#822

... but then when I did a deploy of docs.dhall-lang.org off of dhall-lang/dhall-lang#827 it rolled back the website change because that change had not been merged yet.

I will correct this tonight when I get back home

@Gabriel439

This comment has been minimized.

Copy link
Collaborator Author

Gabriel439 commented Nov 23, 2019

Alright, the site is back to the new version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.