Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Haskell datatype declarations from Dhall types #1620

Merged
merged 5 commits into from Jan 5, 2020
Merged

Conversation

@Gabriel439
Copy link
Collaborator

Gabriel439 commented Jan 3, 2020

Fixes #1616

This adds a new Dhall.TH.makeHaskellType utility which generates a
Haskell datatype declaration corresponding to a Dhall type. This simplifies
keeping Haskell and Dhall code in sync with one another.

Fixes #1616

This adds a new `Dhall.TH.makeHaskellType` utility which generates a
Haskell datatype declaration corresponding to a Dhall type.  This simplifies
keeping Haskell and Dhall code in sync with one another.
Copy link
Collaborator

sjakobi left a comment

This looks great! Nevertheless I have some questions. :)

dhall/src/Dhall/TH.hs Outdated Show resolved Hide resolved
dhall/src/Dhall/TH.hs Show resolved Hide resolved
nix/shared.nix Show resolved Hide resolved
Gabriel439 added 2 commits Jan 5, 2020
... as suggested by @sjakobi
@sjakobi
sjakobi approved these changes Jan 5, 2020
Copy link
Collaborator

sjakobi left a comment

🎉

I wonder how we could handle function types and e.g. Optionals or Lists, but I think we can delay that until someone requests it.

@Gabriel439 Gabriel439 added the merge me label Jan 5, 2020
@mergify mergify bot merged commit b028082 into master Jan 5, 2020
4 checks passed
4 checks passed
Summary 2 rules match
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hydra Hydra build #48977 of dhall-haskell:1620:dhall
Details
@mergify mergify bot deleted the gabriel/1616 branch Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.