New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy binaries to GitHub Releases #181

Merged
merged 1 commit into from Nov 21, 2017

Conversation

Projects
None yet
2 participants
@joneshf
Collaborator

joneshf commented Nov 20, 2017

Sorry for not asking first. Feel free to close this PR if you'd prefer not to have it. If you have changes you'd like, let me know!

What this does

It's basically the same as the stuff from dhall-json.

This should build on OSX as well as Linux.
When there is a git tag, the build should create a Release on GitHub.
The Release should have the built binaries for OSX and Linux.

What you need to do to make things work

This uses a personal access token to allow Travis to create Releases and upload artifacts.

You need to:

  1. Generate new token for Travis to use: https://github.com/settings/tokens.
  2. The scope it needs is repo:public: https://docs.travis-ci.com/user/deployment/releases/#Authenticating-with-an-OAuth-token.
  3. Set that token as the Environment Variable GITHUB_OAUTH_TOKEN in the travis settings: https://travis-ci.org/joneshf/dhall-json/settings

After that, any tag you push should create a GitHub Release.

Deploy binaries to GitHub Releases
This should build on OSX as well as Linux.
When there is a git tag, the build should create a Release on GitHub.
The Release should have the built binaries for OSX and Linux.
@Gabriel439

This comment has been minimized.

Show comment
Hide comment
@Gabriel439

Gabriel439 Nov 20, 2017

Collaborator

I don't mind at all! Thank you for doing this :)

Collaborator

Gabriel439 commented Nov 20, 2017

I don't mind at all! Thank you for doing this :)

@Gabriel439 Gabriel439 merged commit 755f91b into dhall-lang:master Nov 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joneshf joneshf deleted the joneshf:patch-1 branch Nov 21, 2017

@joneshf

This comment has been minimized.

Show comment
Hide comment
@joneshf

joneshf Nov 21, 2017

Collaborator

Looks like the OSX build timed out as it was about to deploy: https://travis-ci.org/dhall-lang/dhall-haskell/jobs/305034959#L6892.

But it also looks like it built a cache and uploaded it before then: https://travis-ci.org/dhall-lang/dhall-haskell/jobs/305034959#L6835-L6843

Maybe a restart would finish under the time limit?

Collaborator

joneshf commented Nov 21, 2017

Looks like the OSX build timed out as it was about to deploy: https://travis-ci.org/dhall-lang/dhall-haskell/jobs/305034959#L6892.

But it also looks like it built a cache and uploaded it before then: https://travis-ci.org/dhall-lang/dhall-haskell/jobs/305034959#L6835-L6843

Maybe a restart would finish under the time limit?

@Gabriel439

This comment has been minimized.

Show comment
Hide comment
@Gabriel439

Gabriel439 Nov 21, 2017

Collaborator

Yeah, a restart fixed the issue

Collaborator

Gabriel439 commented Nov 21, 2017

Yeah, a restart fixed the issue

joneshf added a commit to joneshf/node-dhall-haskell-bin that referenced this pull request Nov 21, 2017

Support OSX as well
The binaries exist now:
dhall-lang/dhall-haskell#181 (comment)
So, we ought to support them here explicitly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment