Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix potential type-checker bugs #198
Conversation
Gabriel439
merged commit 2129e75
into
master
Dec 29, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Gabriel439
deleted the
gabriel/fix_semantics
branch
Dec 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Gabriel439 commentedDec 29, 2017
As part of formalizing the semantics of Dhall there are a few places
where the type-checker was missing a type-check to ensure that an
expression was safe to normalize. This change fixes those few
type-checking holes.
See: dhall-lang/dhall-lang#61