Implement with without syntactic sugar
#2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as standardized in dhall-lang/dhall-lang#1073
… by restoring the `desugarWith` utility, even if it's only used by `dhall-nix`
sjakobi
approved these changes
Sep 28, 2020
… as caught by @sjakobi Co-authored-by: Simon Jakobi <simon.jakobi@gmail.com>
|
I see you're making further changes to the Are there any plans on shipping a v1.35.1 that would include these fixes soon? I'm asking because we are heavy users of |
|
@JohannesRudolph: We release monthly, so there should be a new release coming out soon (~1 week) #2048 added a regression test to ensure that the original problem won't recur, so you don't need to worry about any regressions due to the subsequent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… as standardized in dhall-lang/dhall-lang#1073