Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve string interpolation when using dhall-format #220

Merged
merged 4 commits into from Jan 22, 2018

Conversation

Gabriella439
Copy link
Collaborator

Fixes #216

This changes the internal representation of TextLit to be able to
store an interpolated string literal. Preserving string interpolation in
the syntax tree means that dhall-format can also preserve
interpolation.

This also simplifies a lot of the string-interpolation-related code,
which is now simpler and more strongly typed.

Fixes #216

This changes the internal representation of `TextLit` to be able to
store an interpolated string literal.  Preserving string interpolation in
the syntax tree means that `dhall-format` can also preserve
interpolation.

This also simplifies a lot of the string-interpolation-related code,
which is now simpler and more strongly typed.
@ocharles
Copy link
Member

Looks good! Maybe worth throwing in my example in #216 as a regression test?

@Gabriella439 Gabriella439 merged commit 4e94f63 into master Jan 22, 2018
@Gabriella439 Gabriella439 deleted the gabriel/format_interpolation branch January 22, 2018 00:32
@ocharles
Copy link
Member

Oh btw, there is still a comment at the top of dhall-format's main stating that it doesn't preserve text interpolation - but now it does! 🍾

@Gabriella439
Copy link
Collaborator Author

Oh, good catch! I'll fix that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants