Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upIncrease connection timeout for imports #37
Conversation
This comment has been minimized.
This comment has been minimized.
|
Yeah, great idea! Sorry about picking such a strict default initially |
Gabriel439
merged commit 649acf3
into
dhall-lang:master
Apr 16, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
markus1189 commentedApr 16, 2017
•
edited
TL;DR
Set the response timeout from 1s to 30s, because 1s is much too optimistic.
Why
From time to time I have the problem luck of being with a rather modest internet connection (~376Kb/s) and I noticed that even running something simple like:
via
dhallfails withConnectionTimeout. I saw that the connection response timeout is set to1 second, which is much too short for a bad internet connection.How
To address this, I raised the time limit from
1 secondto30 seconds, because that is also the time that is used in the defaultmanagerResponseTimeout(https://hackage.haskell.org/package/http-client-0.5.6.1/docs/src/Network-HTTP-Client-Types.html#ManagerSettings).With that setting I can finally use
dhalleven when I don't have a fast internet connection available. :D