Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upadd Type and Interpret instance for strict Text #82
Conversation
Gabriel439
reviewed
Jul 2, 2017
src/Dhall.hs
Outdated
| >>> input text' "\"Test\"" | ||
| "Test" | ||
| -} | ||
| text' :: Type Data.Text.Text |
This comment has been minimized.
This comment has been minimized.
Gabriel439
Jul 2, 2017
Collaborator
Minor suggestion: perhaps call this strictText and rename the old one to lazyText. It's okay if it's a breaking change
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Oh, I also forgot to export |
chris-martin
force-pushed the
chris-martin:pr/strict-text
branch
from
a7d62a9
to
8adf52d
Jul 2, 2017
This comment has been minimized.
This comment has been minimized.
|
Updated, now has |
chris-martin
force-pushed the
chris-martin:pr/strict-text
branch
from
8adf52d
to
7bf4f60
Jul 2, 2017
This comment has been minimized.
This comment has been minimized.
|
Thanks for adding this! :) |
Gabriel439
merged commit 7a0c03d
into
dhall-lang:master
Jul 2, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
chris-martin
deleted the
chris-martin:pr/strict-text
branch
Jul 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
chris-martin commentedJul 2, 2017
This instance is nice to have if you want
Generic-derivedInterpretinstances for types where yourTextdoesn't happen to be of the lazy variety.