Change YAML/JSON encoding for NaN/Infinity/-Infinity
#946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, `dhall-to-json`/`dhall-to-yaml` would use approximate representations for special `Double` values. Specifically, `NaN` would encode as `null` and `±Infinity` would encode as the minimum and maximum `Double` values. After this change, YAML will now use `nan`/`inf`/`-inf` to encode these values (since special `Double` values are natively supported by YAML) and the JSON encoding will reject them by default. The user can restore the old behavior for the JSON encoding by enabling the `--approximate-special-doubles` flag.
|
Note that #941 removes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before,
dhall-to-json/dhall-to-yamlwould use approximaterepresentations for special
Doublevalues. Specifically,NaNwould encode as
nulland±Infinitywould encode as the minimumand maximum
Doublevalues.After this change, YAML will now use
nan/inf/-infto encodethese values (since special
Doublevalues are natively supportedby YAML) and the JSON encoding will reject them by default. The
user can restore the old behavior for the JSON encoding by enabling
the
--approximate-special-doublesflag.