Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hashes for Prelude functions that started using empty alternatives #480

Merged
merged 2 commits into from Apr 13, 2019

Conversation

Projects
None yet
3 participants
@f-f
Copy link
Member

f-f commented Apr 10, 2019

This PR updates the hashes for the Prelude functions that started using empty alternatives.

How I noticed: we have import-alternatives on every field of the package.dhall files, but it seems that "hash breakage" is not included in the "tolerated failures" (so kinda defeating the purpose of the alternatives there).
E.g. this is what happens when trying to import the Prelude (on current master for both dhall-haskell and dhall-lang):

 $ dhall hash <<< "./dhall-lang/Prelude/package.dhall"

Error: Import integrity check failed

Expected hash:

↳ 7b511e6278c1efdc329e163550537603e0fccf3d077a7fa185070c588de1e2c9

Actual hash:

↳ 46b81a9e211fb8278bf2793e75e8175fef79e0e3e478ef1016e3233ecc2ddfe6

I think this is a bug in the standard, as we don't specify that "hash mismatch" counts as a failure for the ? operator - we only mention things like "missing envvars", "file not found", etc (relevant section in the standard, see the end)

@singpolyma

This comment has been minimized.

Copy link
Collaborator

singpolyma commented Apr 10, 2019

@f-f

This comment has been minimized.

Copy link
Member Author

f-f commented Apr 10, 2019

@singpolyma also dhall-clj has the same behaviour - any failure triggers the fallback for ?

I opened #481 to fix the standard

@f-f f-f merged commit cfd9381 into master Apr 13, 2019

1 check passed

hydra Hydra build #10254 of dhall-lang:480:dhall-lang
Details

f-f added a commit that referenced this pull request Apr 14, 2019

Add more failures to the triggers of the `?` operator fallback (#481)
As we identified in #480, the standard was underspecified on this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.