Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiline test #527

Merged
merged 3 commits into from May 6, 2019
Merged

Conversation

singpolyma
Copy link
Collaborator

I think my git settings ate the whitespace, since it was so malformed
intentionally for the test.

I think my git settings ate the whitespace, since it was so malformed
intentionally for the test.
philandstuff
philandstuff previously approved these changes May 5, 2019
@philandstuff
Copy link
Collaborator

Hmm, I checked out the branch and got errors running it through cbor2pretty.rb and cbor2yaml.rb:

$ cbor2pretty.rb dhall-lang/tests/parser/success/text/multilineCorruptedLeadingWhitespaceB.dhallb
Traceback (most recent call last):
	4: from /home/philandstuff/.nix-profile/bin/cbor2pretty.rb:18:in `<main>'
	3: from /home/philandstuff/.nix-profile/bin/cbor2pretty.rb:18:in `load'
	2: from /nix/store/agr0i5lj0s3aj5909q9d3r7jwr0xdr7n-cbor-diag-0.5.2/lib/ruby/gems/2.5.0/gems/cbor-diag-0.5.2/bin/cbor2pretty.rb:7:in `<top (required)>'
	1: from /nix/store/jq9mhr5mkmjbhax7rxx313z1172qsl6v-ruby2.5.5-cbor-diag-0.5.2/lib/ruby/gems/2.5.0/gems/cbor-diag-0.5.2/lib/cbor-pretty.rb:17:in `pretty'
/nix/store/jq9mhr5mkmjbhax7rxx313z1172qsl6v-ruby2.5.5-cbor-diag-0.5.2/lib/ruby/gems/2.5.0/gems/cbor-diag-0.5.2/lib/cbor-pretty.rb:79:in `pretty_item_final': unhandled exception

$ cbor2yaml.rb dhall-lang/tests/parser/success/text/multilineCorruptedLeadingWhitespaceB.dhallb
Traceback (most recent call last):
	4: from /home/philandstuff/.nix-profile/bin/cbor2yaml.rb:18:in `<main>'
	3: from /home/philandstuff/.nix-profile/bin/cbor2yaml.rb:18:in `load'
	2: from /nix/store/agr0i5lj0s3aj5909q9d3r7jwr0xdr7n-cbor-diag-0.5.2/lib/ruby/gems/2.5.0/gems/cbor-diag-0.5.2/bin/cbor2yaml.rb:14:in `<top (required)>'
	1: from /nix/store/jq9mhr5mkmjbhax7rxx313z1172qsl6v-ruby2.5.5-cbor-diag-0.5.2/lib/ruby/gems/2.5.0/gems/cbor-diag-0.5.2/lib/cbor-pure.rb:78:in `decode'
/nix/store/jq9mhr5mkmjbhax7rxx313z1172qsl6v-ruby2.5.5-cbor-diag-0.5.2/lib/ruby/gems/2.5.0/gems/cbor-diag-0.5.2/lib/cbor-pure.rb:300:in `decode_item_final': extra bytes follow after a deserialized object of 20 bytes (RuntimeError)

I think there's a trailing byte 0a (newline) which should be removed.

@philandstuff philandstuff dismissed their stale review May 5, 2019 16:28

I have tested it and it didn't work for me

Copy link
Collaborator

@philandstuff philandstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit which fixed the CBOR

@singpolyma singpolyma merged commit 2ae7c0c into dhall-lang:master May 6, 2019
@singpolyma singpolyma deleted the fix-multiline-test branch May 6, 2019 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants