Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize `constructors` keyword #63

Merged
merged 4 commits into from Jan 3, 2018

Conversation

Projects
None yet
2 participants
@Gabriel439
Copy link
Contributor

commented Dec 29, 2017

@@ -266,6 +266,7 @@ in = %x69.6e whitesp
as = %x61.73 whitespace
using = %x75.73.69.6e.67 whitespace
merge = %x6d.65.72.67.65 whitespace
constructors = %x63.6f.6e.73.74.72.75.63.74.6f.72.7 whitespace

This comment has been minimized.

Copy link
@pyrtsa

pyrtsa Jan 2, 2018

This literal doesn’t seem to end right?

This comment has been minimized.

Copy link
@Gabriel439

Gabriel439 Jan 2, 2018

Author Contributor

Whoops. You're right. I'll fix this

Gabriel439 added some commits Jan 2, 2018

Fix incorrect typing judgment
The first typing judgment for `constructors` was incorrect since
it should be for the case where the argument normalizes to an
empty union type, not for when the argument's inferred type is an
empty union type.

@Gabriel439 Gabriel439 merged commit 631b3e4 into master Jan 3, 2018

@Gabriel439 Gabriel439 deleted the gabriel/constructors branch Jan 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.