Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prelude: Document connection to Monoid for Bool/even and Bool/odd #683

Merged
merged 3 commits into from Aug 7, 2019

Conversation

@sjakobi

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 6, 2019

Since this is not a standard change, is this good to merge already?

@Gabriel439

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

@sjakobi: Changes to the Prelude are treated the same way as changes to the standard. See: https://github.com/dhall-lang/dhall-lang/blob/master/.github/CONTRIBUTING.md#how-do-changes-get-approved

@sjakobi

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 6, 2019

Oops, I misremembered that. Thanks for clearing it up @Gabriel439! :)

@Gabriel439

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

@sjakobi: You're welcome! 🙂

@f-f

f-f approved these changes Aug 6, 2019

@sjakobi sjakobi merged commit 20e78e3 into master Aug 7, 2019

1 check passed

hydra Hydra build #27657 of dhall-lang:683:dhall-lang
Details

@sjakobi sjakobi deleted the sjakobi/bool-even-odd-docs branch Aug 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.