Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add migration plan for Optional/fold and Optional/build deprecations #880

Merged
merged 5 commits into from Jan 20, 2020

Conversation

@sjakobi
Copy link
Collaborator

sjakobi commented Jan 10, 2020

Closes #869.

Copy link
Collaborator Author

sjakobi left a comment

@f-f @singpolyma @Nadrieril Could you let me know when you expect to implement the phases of this migration, so I can update the versions in the plan?

If there are any other implementations that would like to be included, please let me know!

* Phase 3 - Remove the `Optional/fold` and `Optional/fold` builtins

* Standard version: 17.0.0
* Clojure implementation version: To be determined

This comment has been minimized.

Copy link
@f-f

f-f Jan 11, 2020

Member

dhall-clj is effectively frozen at the moment, could we drop it from the list here?

This comment has been minimized.

Copy link
@sjakobi

sjakobi Jan 12, 2020

Author Collaborator

Done! :)

This comment has been minimized.

Copy link
@f-f

f-f Jan 12, 2020

Member

Thank you! 🙂

@f-f
f-f approved these changes Jan 13, 2020
* Phase 1 - Extend `merge` to work on `Optional`s

* Standard version: [13.0.0](https://github.com/dhall-lang/dhall-lang/releases/tag/v13.0.0)
* Haskell implementation version: 1.29.0

This comment has been minimized.

Copy link
@singpolyma

singpolyma Jan 14, 2020

Collaborator

I disagree with including implementation-specific information here. Implementations can document what language versions they support, and thus the deprecation situation can be determined.

This comment has been minimized.

Copy link
@sjakobi

sjakobi Jan 14, 2020

Author Collaborator

@singpolyma You're correct that this information is somewhat redundant. But since deprecations are already such a hassle for users, I think it's good to make the process as smooth as possible, and IMHO that means including this version info. This info should be particularly useful for users who use multiple implementations on the same code base.

If you prefer, I can of course remove dhall-ruby from the plan.

sjakobi added 2 commits Jan 16, 2020
@sjakobi sjakobi merged commit 004eaed into master Jan 20, 2020
1 check passed
1 check passed
hydra Hydra build #49779 of dhall-lang:880:dhall-lang
Details
@sjakobi sjakobi deleted the sjakobi/deprecate-opt-fold-build branch Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.