Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text editor configuration howtos #907

Merged
merged 5 commits into from Feb 9, 2020

Conversation

@TristanCacqueray
Copy link
Collaborator

TristanCacqueray commented Feb 6, 2020

This change adds instructions to configure the dhall-lsp-server
with different text editors.

@TristanCacqueray

This comment has been minimized.

Copy link
Collaborator Author

TristanCacqueray commented Feb 6, 2020

This is a WIP I meant to share with colleagues. If someone wants to take it over, please feel free to do so.
About vscode, should https://github.com/dhall-lang/dhall-haskell/tree/master/dhall-lsp-server#dhall-language-support-in-vscodeium be simply integrated here?

@TristanCacqueray TristanCacqueray force-pushed the TristanCacqueray:ide-lsp branch from 44a8092 to 3a777c3 Feb 7, 2020
Copy link
Contributor

Gabriel439 left a comment

Thanks for doing this! Once this is merged you can claim the documentation bounty from https://discourse.dhall-lang.org/t/expense-proposal-document-language-server-setup/121/2

docs/howtos/Text-Editor-Configuration.md Outdated Show resolved Hide resolved
docs/howtos/Text-Editor-Configuration.md Outdated Show resolved Hide resolved
docs/howtos/Text-Editor-Configuration.md Show resolved Hide resolved
@Gabriel439

This comment has been minimized.

Copy link
Contributor

Gabriel439 commented Feb 8, 2020

@TristanCacqueray: For VSCode, I think it's enough to document how to install the plugin and then just link to the README for anything else

This change adds instructions to configure the dhall-lsp-server
with different text editors.
@TristanCacqueray TristanCacqueray force-pushed the TristanCacqueray:ide-lsp branch from 3a777c3 to ca3673a Feb 8, 2020
@TristanCacqueray

This comment has been minimized.

Copy link
Collaborator Author

TristanCacqueray commented Feb 8, 2020

@Gabriel439 Thank you for the suggestions, please let me know if the instructions need more works.

I am not interested by the bounty, though I am curious to see how this works in practice. In the end I would use it as a donation to the collective.

Copy link
Contributor

Gabriel439 left a comment

Looks great! I tested out all three mechanisms and they worked for me

Also, if you plan on returning the bounty back to the collective fund it's probably simpler to not collect the bounty (to avoid incurring tax)

@TristanCacqueray

This comment has been minimized.

Copy link
Collaborator Author

TristanCacqueray commented Feb 9, 2020

Thank you for the review :) Last commit just improves the screenshot.

If you don't mind canceling the bounty, that sounds easier.

@Gabriel439

This comment has been minimized.

Copy link
Contributor

Gabriel439 commented Feb 9, 2020

@TristanCacqueray: Alright, then I'll cancel the bounty. Thank you for contributing this! 🙂

@Gabriel439 Gabriel439 merged commit acb8216 into dhall-lang:master Feb 9, 2020
1 check passed
1 check passed
hydra Hydra build #51302 of dhall-lang:907:dhall-lang
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.