New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bootstrap option for views #8

Merged
merged 1 commit into from Nov 23, 2014

Conversation

Projects
None yet
2 participants
@joshuapaling
Contributor

joshuapaling commented Oct 12, 2014

For now, I've added ERB views only - no HAML yet. Resolves feature reqeust #6

There's still probably some improvements to make - but should be easy fixes from here.

Here's some screenshots of the bootstrap views:

screen shot 2014-10-12 at 9 20 53 pm
screen shot 2014-10-12 at 9 20 43 pm
screen shot 2014-10-12 at 9 20 38 pm
screen shot 2014-10-12 at 9 20 29 pm
screen shot 2014-10-12 at 9 20 23 pm

@dhampik

This comment has been minimized.

Owner

dhampik commented Oct 13, 2014

Thanks a lot for your efforts. Looks good. I'll check and merge this PR soon.

@joshuapaling

This comment has been minimized.

Contributor

joshuapaling commented Nov 6, 2014

@dhampik have you had a chance to take a look at this?

@dhampik

This comment has been minimized.

Owner

dhampik commented Nov 17, 2014

Sorry for not responding for so long. I have some personal issues, so can't do it right now (didn't even have access to computer). Hopefully I'll manage to accept PR and release new version of gem in 2 weeks or so.
Probably, for now it's better to put the following line into Gemfile to use this feature (in case if anyone needs it):

gem 'rails-admin-scaffold', github: 'joshuapaling/rails-admin-scaffold'

@dhampik dhampik merged commit a3be580 into dhampik:master Nov 23, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@dhampik

This comment has been minimized.

Owner

dhampik commented Nov 23, 2014

Thank you for your efforts, @joshuapaling 👍 !
I also added haml support, fixed some issues with checkboxes styling and released v0.1.0 of a gem.

@dhampik dhampik referenced this pull request Nov 23, 2014

Closed

Add support for bootstrap #6

@joshuapaling

This comment has been minimized.

Contributor

joshuapaling commented Nov 23, 2014

Nice work, thanks!

@joshuapaling joshuapaling deleted the joshuapaling:feature-bootstrap branch Jul 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment