Permalink
Commits on Jun 16, 2016
  1. pep8: fix F405 error

    cliff/argparse.py:9:26: F405 ArgumentParser may be undefined, or defined from star imports: argparse
    
    Change-Id: I3284d90d20932275ac05c7e44749635b7b2d04bf
    jd committed Jun 16, 2016
Commits on Jun 15, 2016
Commits on Jun 10, 2016
  1. Merge "Update --max-width help"

    Jenkins committed with openstack-gerrit Jun 10, 2016
Commits on May 31, 2016
  1. Merge "Refactor HelpCommand"

    Jenkins committed with openstack-gerrit May 31, 2016
Commits on May 26, 2016
  1. Updated from global requirements

    Change-Id: I6ffafa27e3acb9d3ab4c1c7ad947813626fa2da6
    OpenStack Proposal Bot committed May 26, 2016
  2. Update --max-width help

    The --max-width help said that 0 would disable, when in fact any value
    less than 1 would disable. Updated the help to match the behavior.
    
    Change-Id: I36066fb4b54ec857d381ada200fce3fb42d8236c
    Closes-Bug: #1564433
    edmondsw committed Mar 31, 2016
  3. Add more test coverage for shell formatter

    .add_argument_group() was not covered by tests, nor was  parameter "--prefix"
    
    Change-Id: If757613793201defa3d9d7006d3a4a0a2a9a43c2
    Signed-off-by: Vincent Legoll <vincent.legoll@idgrilles.fr>
    vincent-legoll committed May 15, 2016
  4. Add more test coverage for CSV formatter

    .add_argument_group() was not covered by tests,
    nor was quote mode 'all'
    
    Change-Id: I86fdd38a16cbecfd124f203e79ffe75c5678907e
    Signed-off-by: Vincent Legoll <vincent.legoll@idgrilles.fr>
    vincent-legoll committed May 14, 2016
Commits on May 24, 2016
  1. Merge "Factorize more test data"

    Jenkins committed with openstack-gerrit May 24, 2016
  2. Merge "Factorize some test data"

    Jenkins committed with openstack-gerrit May 24, 2016
Commits on May 23, 2016
  1. Merge "Factorize common test code"

    Jenkins committed with openstack-gerrit May 23, 2016
Commits on May 16, 2016
  1. Support multiple sub commands in completion

    This adds completion support for commands with overlapped name as
    cmd_foo/cmd_foo_bar.
    
    Change-Id: I568081ea56479c453f29672153ce8a4100ac7fcb
    Closes-Bug: #1549749
    therve committed Feb 25, 2016
Commits on May 14, 2016
  1. Factorize more test data

    Change-Id: I1e4a322e02435e42177f58fcd61c5f0de5f93941
    Signed-off-by: Vincent Legoll <vincent.legoll@idgrilles.fr>
    vincent-legoll committed May 11, 2016
  2. Factorize some test data

    Change-Id: Ieba27fe754c3f62944247bcdc214e37e7f9f4adc
    Signed-off-by: Vincent Legoll <vincent.legoll@idgrilles.fr>
    vincent-legoll committed May 11, 2016
Commits on May 13, 2016
  1. Merge "Factorize argparse importing"

    Jenkins committed with openstack-gerrit May 13, 2016
  2. Factorize common test code

    Add doc & comments
    
    Change-Id: I0b0438798c2c6bde82f27784193424860e947fe8
    Signed-off-by: Vincent Legoll <vincent.legoll@idgrilles.fr>
    vincent-legoll committed May 11, 2016
  3. Merge "Updated from global requirements"

    Jenkins committed with openstack-gerrit May 13, 2016
  4. Factorize argparse importing

    Change-Id: I6bf56ee1a27b661cf72c2953bb5d1a5c45d14810
    Signed-off-by: Vincent Legoll <vincent.legoll@idgrilles.fr>
    vincent-legoll committed May 11, 2016
Commits on May 12, 2016
  1. Updated from global requirements

    Change-Id: I5dad6a7ea389d54e44fd8dd46efd86f121b55933
    OpenStack Proposal Bot committed May 12, 2016
Commits on May 10, 2016
  1. Updated from global requirements

    Change-Id: I26ddde092bb19cb242f77b1d2caf028b92deb044
    OpenStack Proposal Bot committed May 10, 2016
Commits on May 8, 2016
  1. Add CLIFF_MAX_TERM_WIDTH envvar to complement --max-width

    Some cliff clients tailors their output according to characteristics
    of the terminal they outputs text to. They detect the width of the
    terminal in order to pretty print text properly cut to line length.
    
    There are situations where the output is not in a "real" terminal
    but in some kind of emulation or redirected layer for which this
    line length interpretation is not ideal. For example in a bash
    jupyter-notebook.
    
    There already exist the --max-width CLI parameter to allow that
    to be customized, but there are cases where you don't want to
    use an additional parameter. So add an environment variable
    that has the same meaning, to help avoiding the use of
    --max-width.
    
    Without the parameter nor the envvar, the behaviour should stay
    the same as before the patch, i.e. the output is cut to terminal
    line length. The envvar is then used to give the parameter's
    default value, so the parameter will stay being the final one
    deciding of the behaviour when used.
    
    Add mock'ed testing for the new CLIFF_MAX_TERM_WIDTH envvar.
    Add mock'ed tests to ensure parameter vs envvar priority.
    Add testing for actual parameter parsing & priority vs envvar.²
    
    This has been discussed in:
    https://bugs.launchpad.net/python-openstackclient/+bug/1577368
    https://bugs.launchpad.net/python-cliff/+bug/1485847/comments/7
    
    Closes-Bug: 1577368
    Related-Bug: 1485847
    
    Change-Id: I0ab988ea0e7087960a9bfb2353f46918f0333a53
    Signed-off-by: Vincent Legoll <vincent.legoll@idgrilles.fr>
    vincent-legoll committed May 7, 2016
Commits on May 7, 2016
  1. Fix prettytable.PrettyTable().max_width wrong usage

    prettytable.PrettyTable().max_width sets *per-column* max_width
    which is not what we want here. What we want to set is *total
    line length*. So go through the _assign_max_widths() code that
    does that for the other cases, and get it right.
    
    Change-Id: I11b0b2ec18de8f59759f52647afba6e4ae7917c6
    Signed-off-by: Vincent Legoll <vincent.legoll@idgrilles.fr>
    vincent-legoll committed May 7, 2016
Commits on Apr 22, 2016
  1. Merge "Sync help message for --help"

    Jenkins committed with openstack-gerrit Apr 22, 2016
Commits on Apr 20, 2016
  1. Fix AttributeError when entry point load failed

    If some entry points load failed because of python lib version confilct
    when we run "openstack help" command. cliff catch loading fail exception
    and try to print the exception traceback, but that cause an
    AttributeError.
    
    This patch fix the issue and add related unit test case.
    
    Change-Id: I4f9e24f85b0992cd2aa999589277cfdcf4cac4aa
    Closes-Bug: #1554408
    Rui Chen committed Mar 8, 2016
  2. Distinguish no existed columns in ShowOne

    If we show a resource with no existed column, ShowOne command
    don't raise any warning and notify that we are doing some
    wrong things, the suitable behavior should be like as Lister
    command, output the no recognized column names.
    
    Change-Id: I5a698653a683c00dd3e3e41c3b381f3d4dac2c08
    Closes-Bug: #1548701
    Rui Chen committed Feb 24, 2016
  3. Refactor HelpCommand

    Move parser.print_help() into suitable code block.
    
    Change-Id: Iabc5c574d19ae204f2e44be5b857e498c3cfc449
    Rui Chen committed Feb 23, 2016
Commits on Apr 19, 2016
  1. Updated from global requirements

    Change-Id: Ic4bcb34c8c442630f7b3f45ff62fa6f38c845fc3
    OpenStack Proposal Bot committed Apr 19, 2016
Commits on Mar 14, 2016
  1. Remove httplib2 from test-requirements.txt

    It's not being used and shouldn't be needed
    
    Change-Id: Ib3d92b54c1960fbd73c98c16ffa80575bd358232
    JAORMX committed Mar 14, 2016
Commits on Feb 27, 2016
  1. Sync help message for --help

    Between the command help and the sub commands help.
    
    Change-Id: I4e38db7852d7d168cf46b82973778b70e802f2ee
    to222 committed Feb 27, 2016