Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 8 Runtime Support #852

Open
wants to merge 6 commits into
base: master
from
Open

Java 8 Runtime Support #852

wants to merge 6 commits into from

Conversation

@bytekast
Copy link

bytekast commented Dec 6, 2019

Adds support for invoking Java-based Lambda functions. This runner relies on the specified deployment package in the serverless.yml. It does not care how the package is built or which build system is used (ant, maven, gradle, etc.)

@bytekast bytekast force-pushed the bytekast:java8-runtime branch from de2be83 to bddf232 Dec 6, 2019
@bytekast

This comment has been minimized.

Copy link
Author

bytekast commented Dec 6, 2019

not exactly sure why the linux/osx builds are failing. just tested in 2 osx machines and an ubuntu machine and they worked fine.

@bytekast bytekast force-pushed the bytekast:java8-runtime branch from d8e45bd to c5c3385 Dec 6, 2019
bytekast added 2 commits Dec 7, 2019
@dnalborczyk

This comment has been minimized.

Copy link
Collaborator

dnalborczyk commented Dec 10, 2019

hey @bytekast thank you for the time and effort you put into this PR! java support would be a welcomed addition to the project!

just quickly glanced over the PR (still occupied with the docker PR) and without knowing much about java I wonder if it's possible to rather pull-in the dependency entirely into the project: https://github.com/dherault/serverless-offline/pull/852/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R156 . I'm also wondering if it's necessary to spin up 2 child processes (with execa and child_process in the referenced module)?

@bytekast

This comment has been minimized.

Copy link
Author

bytekast commented Dec 10, 2019

@dnalborczyk I plan on possibly re-using to the dependency for invoke local so I'd like to keep it as a library if that's okay?
regarding the child processes, I'll update the PR to only spin up one. thanks!

@dnalborczyk dnalborczyk force-pushed the dherault:master branch from 70cc3ca to c72ea53 Dec 18, 2019
@kinpatel

This comment has been minimized.

Copy link

kinpatel commented Jan 8, 2020

Any updates on the merge? I would really like to use the updated version with java support.

@dnalborczyk

This comment has been minimized.

Copy link
Collaborator

dnalborczyk commented Jan 10, 2020

hey @bytekast I'll have a look in the next couple days /cc @jef

Copy link

jef left a comment

test looks accurate, just the one comment. other than that, looks good to me.

body: data,
}

const response = await fetch('http://localhost:8080/invoke', httpOptions)

This comment has been minimized.

Copy link
@jef

jef Jan 11, 2020

maybe this port should be configurable?

@dnalborczyk dnalborczyk force-pushed the dherault:master branch from b01460f to 80bf2a5 Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.