New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters to calls must be coerced (to int or double, or to a subtype of extern) #61

Closed
cscott opened this Issue Jun 5, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@cscott

cscott commented Jun 5, 2013

Changes were made to asm.js in mozilla bug 864600 to support single-pass compilation. These changes have not yet been propagated back to the spec.

In particular, call parameters must be coerced: local function/function table call parameters must be coerced to double or int, FFI call parameters must be coerced to a subtype of extern, and global imports don't need any extra coercion (beyond their function signature, given in the spec).

(Comment 4 on bug 864600 also describes two other related changes which are covered by gh issue 71 and gh issue 62.)

@cscott

This comment has been minimized.

Show comment
Hide comment
@cscott

cscott Jun 19, 2013

Updated the issue description to more precisely describe the spec changes called for.

cscott commented Jun 19, 2013

Updated the issue description to more precisely describe the spec changes called for.

@sunfishcode

This comment has been minimized.

Show comment
Hide comment
@sunfishcode

sunfishcode Jun 3, 2014

Collaborator

Fixed in 7881fbe.

Collaborator

sunfishcode commented Jun 3, 2014

Fixed in 7881fbe.

@sunfishcode sunfishcode closed this Jun 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment