Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore errors unloading OpenAL data. mitigates #178

Merged
merged 1 commit into from Jan 30, 2020

Conversation

coreyoconnor
Copy link
Contributor

@coreyoconnor coreyoconnor commented May 13, 2019

Not a real fix. Sufficient to avoid the issue for my play sessions tho. :)

@och-dx
Copy link

och-dx commented Jan 29, 2020

Can I use this fix without recompiling? Noob here.

@coreyoconnor
Copy link
Contributor Author

coreyoconnor commented Jan 29, 2020

No: This patch requires recompiling. What platform are you on?

Note to devs: Just noticed this has incorrect indentation. oops!

@och-dx
Copy link

och-dx commented Jan 29, 2020

No: This patch requires recompiling. What platform are you on?

Note to devs: Just noticed this has incorrect indentation. oops!

Windows 10 pro 64 bit

@DanielGibson
Copy link
Member

DanielGibson commented Jan 29, 2020

@coreyoconnor can you fix the indentation (and ideally amend the commit and force-push it), then I'll merge it

I can build new windows binaries that include this fix this weekend if no one beats me to it

@och-dx
Copy link

och-dx commented Jan 29, 2020

You guys are freaking awesome!

@och-dx
Copy link

och-dx commented Jan 29, 2020

Also, is it worth it to use updated version of OpenAL soft? Should I be using 32 or 64 bit library?

@coreyoconnor
Copy link
Contributor Author

coreyoconnor commented Jan 30, 2020

@coreyoconnor can you fix the indentation (and ideally amend the commit and force-push it), then I'll merge it

done! let me know if I missed anything :)

@DanielGibson DanielGibson merged commit 636c3a0 into dhewm:master Jan 30, 2020
@DanielGibson
Copy link
Member

DanielGibson commented Jan 30, 2020

thanks!

@och-dx
Copy link

och-dx commented Jan 30, 2020

So does this mean you will upload a new version to the main site?

@DanielGibson
Copy link
Member

DanielGibson commented Jan 30, 2020

I think I'll upload it here or in the issue (#178) first to find out if it actually fixes your problem.
But I won't get around to creating it before the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants