Master server working again

[Stradex]

So this was the real issue after all. (the thing about si_version etc.. was nothing but a false-positive because I was testing after using the original Doom 3 steam version so probably the cache did saved my ip and port in the masterserver for a while)

[Stradex]

A bit more of explanation why this works:

dhewm3 code did remove the following line from idAsyncServer::ProcessGetInfoMessage :

outMsg.WriteLong( fileSystem->GetOSMask() );

(Look at this: https://github.com/TTimo/doom3.gpl/blob/aaa855815ab484d5bd095f347163194ac569abcc/neo/framework/async/AsyncServer.cpp )

because GetOSMask does not exists anymore, but the master server expects that info to be received seems (even if there is no use for them maybe), so adding outMsg.WriteInt( -1 ); fixsthe problem.

[turol]

You should add a comment about what this magic -1 is and why it is.

[Kalamatee]

it would be nice if it was set using a cvar that could be overridden if necessary.

…

On Wed, 27 May 2020 at 11:57, Turo Lamminen ***@***.***> wrote: You should add a comment about what this magic -1 is and why it is. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#293 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACWCNPE3RSEEFZCYSMAYSELRTTWYLANCNFSM4NL65DRQ> .

[DanielGibson]

it would be nice if it was set using a cvar that could be overridden if necessary.

when should that be necessary?

To elaborate, this should only affect communication between multiplayer servers and the master server, which

1. is hardcoded and can't be changed by the user
2. just doesn't work right now without this change

The network protocol between multiplayer servers and clients playing on them should not be affected, so I don't think this breaks anything.

[Stradex]

Can someone do the pull request with the comment for me?, I am too lazy for doing a pull request again to just adding a comment lol.

[DanielGibson]

I can add the comment, of course :)

Note that you wouldn't have to create a new PR - you could just add a commit to the branch and push it (it gets added to the PR then) or even amend the existing commit and force-push the branch.

[Stradex]

Yeah but I need to restart the pc (I am in linux now, I have everything in windows), open gitbash and aah, I am getting lazy to just think about it right now. haha

btw, the feature was already tested and it is working. Just to you know that this is not a feature without testing.

[DanielGibson]

I pushed the commit to master (after adding a comment), thanks a lot! :)