Fix some small bugs #3

Closed
wants to merge 7 commits into
from

Conversation

3 participants
@DanielGibson
Member

DanielGibson commented May 17, 2012

Most of the fixes are for issues from the iodoom3 bugtracker (some fixes are directly taken from there and others are written from scratch).

Furthermore there's workaround for a very strange bug with broken LADSPA plugins and ALSA ( http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=672704 ).

DanielGibson added some commits May 12, 2012

Work around broken libs that call setlocale(LC_ALL, "");
Because that can fuck up parsing floats if your locale uses ',' as a radix.

LADSPA plugins that may be used by ALSA do this. A PITA to debug.
Fix wrong length used in memset() in idMegaTexture::GenerateMegaMipMa…
…ps()

it should be tileSize, not sizeof( tileSize ), as it was also used for
allocating that block of memory
Fix idMatX::IsOrthonormal()
The original implementation was pretty broken (but not used anyway),
it is now fixed and improved a bit (got rid of one inner loop).
This (at least part of the problem) was detected by PVS-Studio,
see http://www.viva64.com/en/b/0120/ Fragment 3
Fix several bugs from iodoom3 bugtracker
rhyskidd@gmail.com found them (with PVS studio IIRC), reported them and posted
patches.
Some of the patches were incorrect so I rewrote them.
(Hopefully) fix call to LittleRevBytes in idGameLocal::ServerWriteSna…
…pshot()

Makes more sense than before, but TBH I'm not entirely sure what this is
supposed to do.
@andre-d

This comment has been minimized.

Show comment
Hide comment
@andre-d

andre-d May 18, 2012

Contributor

Woa, awesome, if he does not accept them I will pull them into my sdl2 port for sure.

Contributor

andre-d commented May 18, 2012

Woa, awesome, if he does not accept them I will pull them into my sdl2 port for sure.

Remove superfluous call to dict->GetString
it's called again one line below (this time checking if the key really existed
in the dict)
I overlooked this in "Fix several bugs from iodoom3 bugtracker"
@dhewg

This comment has been minimized.

Show comment
Hide comment
@dhewg

dhewg Jun 2, 2012

Member

woo, activity!
pushed most of the stuff: squashed 34a2a07 into 9d5ac74 and dropped 4ab609f, that should prolly be tested by some BE user ;)
thanks!

Member

dhewg commented Jun 2, 2012

woo, activity!
pushed most of the stuff: squashed 34a2a07 into 9d5ac74 and dropped 4ab609f, that should prolly be tested by some BE user ;)
thanks!

@dhewg dhewg closed this Jun 2, 2012

@andre-d

This comment has been minimized.

Show comment
Hide comment
@andre-d

andre-d Jun 2, 2012

Contributor

thanks, rebased my fork up

Contributor

andre-d commented Jun 2, 2012

thanks, rebased my fork up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment