added a simple printing of the key/button pressed #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 23, 2024
BielBdeLuna
changed the title
neo/framework/KeyInput.h
Outdated
| @@ -312,6 +312,7 @@ class idKeyInput { | |||
| static const char * BindingFromKey( const char *key ); | |||
| static bool KeyIsBoundTo( int keyNum, const char *binding ); | |||
| static void WriteBindings( idFile *f ); | |||
| static void KeyReveal( int keyNum ); | |||
There was a problem hiding this comment.
please indent with a tab, like the lines above
neo/framework/KeyInput.cpp
Outdated
| */ | ||
| void idKeyInput::KeyReveal( int keyNum ) { | ||
| const char* keyName = KeyNumToString( keyNum, false ); | ||
| common->Printf( "pressed the \"%s\"key.\n", keyName ); |
There was a problem hiding this comment.
please add a space between \"%s\" and key
|
good idea, apart from the small issues I commented on this looks good to me :) |
|
now done, i made the requested changes changes :) |
|
merged, thank you! :) |
DanielGibson
pushed a commit
that referenced
this pull request
Mar 25, 2024
added a simple helper print method to know what key/button is being pressed, controlled via a bool cvar "in_namePressed" 1 or 0. I tested it and it works with keyboard, mouse and gamepad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a simple helper print method to know what key/button is being pressed, controlled via a bool cvar "in_namePressed" 1 or 0, I tested it and it works with keyboard, mouse and gamepad.