Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Update zip implementation from minizip 0.15 to minizip 1.1 #58

merged 2 commits into from Jun 11, 2013


2 participants

DanielGibson commented Dec 31, 2012

The implementation was more than 10 years old afaik, so I replaced it with a recent one from zlib-1.2.7/contrib/minizip/

Works well for me, but I'd like some testing before merging it..

scaronni commented Jan 4, 2013

I played a few hours, it works for me as long as it deals with playing with the base Doom 3 or with the Resurrection of Evil expansion.

DanielGibson added some commits Dec 31, 2012

@DanielGibson DanielGibson Use updated minizip version for unzip
The implementation is now in framework/minizip/*
instead of framework/Unzip.cpp

This was version 0.15beta, now we use 1.1 from
zlib 1.2.7/contrib/minizip

Some code had to be adjusted for this, but it got
cleaner on the way
@DanielGibson DanielGibson Replace custom unzip functions with standard ones
unz[SG]etCurrentFileInfoPosition() isn't needed anymore,
because newer minizip versions have unz[SG]etOffset() for
that purpose.

@DanielGibson DanielGibson added a commit that referenced this pull request Jun 11, 2013

@DanielGibson DanielGibson Merge pull request #58 from DanielGibson/update-zip
Update zip implementation from minizip 0.15 to minizip 1.1
Should also bring (untested) zip64 support for zip files >2GB.

@DanielGibson DanielGibson merged commit a44af9c into dhewm:master Jun 11, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment