Too narrow field for translation #6

Closed
gipnokote opened this Issue May 20, 2010 · 9 comments

Projects

None yet

2 participants

@gipnokote

Only 2 rows of text is not always enough. Sometimes the translation is much longer than 2 rows of text and it's not comfortable to edit it. I think the height of the textarea should be calculated taking in account number of rows of the default language translation.

@lifo
Collaborator
lifo commented May 20, 2010

Maybe you could send a pull request for this ?

Thanks!

@gipnokote

I'll try :)

@gipnokote

Well I am quite new to githhub and I think I will spend too much time trying to do a pull request, but this is what I did and it worked great for me. I inserted
:style => "height:100%",
into line 39 of app/views/tolk/locales, i mean line with text_area_tag :)

@gipnokote

oops, it worked only for Chrome, not IE or FF :(

@lifo
Collaborator
lifo commented May 20, 2010

Well, that's good enough :) I'll pass this to JZ ( who designed Tolk ) and see what he thinks.

@gipnokote

no no, don't pass it yet, it works only in Chrome, I'll try to find a better solution

@gipnokote

Wow, I explored the thing and now I see that in fact there is a Prototype script in the end of the layout which should adjusts textareas' heights to maximum on execution. And this script didn't work on my project, because I installed Jrails which seems to remove Prototype at all.

So that the issue is invalid, it appears only when you have no Prototype.

@gipnokote

In layout I would call the Prototype library explicitly, not :defaults. In fact it is the only library needed for Tolk, and this change would ensure that Tolk behaves the right way for all folks.

@gipnokote

And by the way, one required function, measure(), is present only in latest Prototype beta version. Ironically, there is an old version of Prototype's "public/javascripts" which doesn't have that function :)

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment