Some fork merges and features #20

Closed
wants to merge 45 commits into
from

Conversation

Projects
None yet
8 participants
@cover

cover commented Nov 24, 2010

  • rails 3 branch
  • tokumine fork in order to add google translate support
  • zencocoon fork in order to add search by key
  • feature to be able to change the primary language when showing a locale, with a fallback to the primary one

lifo and others added some commits Jun 3, 2010

Fabio
Merge branch 'master' of git://github.com/tokumine/tolk
Conflicts:
	app/models/tolk/locale.rb
Fabio
Merge branch 'rails3' of git://github.com/dhh/tolk
Conflicts:
	app/models/tolk/translation.rb
	test/locales/formats/en.yml
@tokumine

This comment has been minimized.

Show comment
Hide comment
@tokumine

tokumine Jan 7, 2011

Would love to see this merge

+1

tokumine commented Jan 7, 2011

Would love to see this merge

+1

@ZenCocoon

This comment has been minimized.

Show comment
Hide comment
@ZenCocoon

ZenCocoon Mar 2, 2011

Commit f15dfc3 is actually a regression. Element.measure is a proper PrototypeJS method introduced in 1.7

Commit f15dfc3 is actually a regression. Element.measure is a proper PrototypeJS method introduced in 1.7

@ZenCocoon

This comment has been minimized.

Show comment
Hide comment
@ZenCocoon

ZenCocoon Mar 2, 2011

A different option at #25
This pull request keep similar functions, no extra like Google Translate or search_key

A different option at #25
This pull request keep similar functions, no extra like Google Translate or search_key

@ZenCocoon

This comment has been minimized.

Show comment
Hide comment
@ZenCocoon

ZenCocoon May 16, 2012

@thomasdarde If you merged #25 and have already done search_key support, only Google Translate should be missing.

@thomasdarde If you merged #25 and have already done search_key support, only Google Translate should be missing.

@thomasdarde

This comment has been minimized.

Show comment
Hide comment
@thomasdarde

thomasdarde May 16, 2012

Collaborator

Ok thanks, I want to add an optional config file for google translate.
There is also the languages name translations, but I don't think it's a good idea.

Collaborator

thomasdarde commented May 16, 2012

Ok thanks, I want to add an optional config file for google translate.
There is also the languages name translations, but I don't think it's a good idea.

@ZenCocoon

This comment has been minimized.

Show comment
Hide comment
@ZenCocoon

ZenCocoon May 16, 2012

Nice idea to have a config file. Google Translate support clearly feels well into such config.

For the languages name translations, it's actually interesting even if I don't like any of the current approaches.

  • all English: not so good if Tolk itself is translated and used by non English (or latin) reader.
  • all native names: as an example, it seems impossible for me to differentiate Chinese and Japanese if written in there native language.

On way approached on public sites is the current language name and the native name together, example, visiting a French version of Tolk would give a language list with :

Anglais - English
Italien - Italiano
...

However, I'm not sure an admin tool such as Tolk needs such polished details. Sure a contribution would feel welcome but doubt it's a priority to focus on.

Nice idea to have a config file. Google Translate support clearly feels well into such config.

For the languages name translations, it's actually interesting even if I don't like any of the current approaches.

  • all English: not so good if Tolk itself is translated and used by non English (or latin) reader.
  • all native names: as an example, it seems impossible for me to differentiate Chinese and Japanese if written in there native language.

On way approached on public sites is the current language name and the native name together, example, visiting a French version of Tolk would give a language list with :

Anglais - English
Italien - Italiano
...

However, I'm not sure an admin tool such as Tolk needs such polished details. Sure a contribution would feel welcome but doubt it's a priority to focus on.

@thomasdarde

This comment has been minimized.

Show comment
Hide comment
@thomasdarde

thomasdarde May 16, 2012

Collaborator

Master version of Tolk now handles a config file.
@tokumine A new contribution linked to Google translate would be much appreciated !

I'm against adding localized locale name directly, I personnaly use the Locale's english_name method of the in an application.
The config file now allows to replace locale names easily.

Collaborator

thomasdarde commented May 16, 2012

Master version of Tolk now handles a config file.
@tokumine A new contribution linked to Google translate would be much appreciated !

I'm against adding localized locale name directly, I personnaly use the Locale's english_name method of the in an application.
The config file now allows to replace locale names easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment