Header spacing #23

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
@bquorning

These 3 commits deals with the header (where it says "Tolk" - [locale])

The first commit removes the horizontal spacing between the two headers. There should be only 1px.

2nd commit pulls content_for :locale from the views into the layout file. When @layout is nil, there is no .empty css class, so I use :first-child and :last-child to round the ends of the header – leaving IE7 and 8 somewhat out of the game.

Last commit links the header locale to tolk_locale_path(@Locale). Always nice to have a link "back" to the main pages.

@bquorning

This comment has been minimized.

Show comment Hide comment
@bquorning

bquorning Jan 5, 2011

Owner

Of course, the headers’ rounded corners and increased padding on first and last elements only work if the browser understands first-child and last-child. Therefore, IEs 7–8 will only round/pad the left side of the headers.

Owner

bquorning commented on 2c95971 Jan 5, 2011

Of course, the headers’ rounded corners and increased padding on first and last elements only work if the browser understands first-child and last-child. Therefore, IEs 7–8 will only round/pad the left side of the headers.

@ZenCocoon

This comment has been minimized.

Show comment Hide comment
@ZenCocoon

ZenCocoon Mar 2, 2011

Also added to #25

Also added to #25

@thomasdarde

This comment has been minimized.

Show comment Hide comment
@thomasdarde

thomasdarde May 16, 2012

Collaborator

Merged into master, expect this improved header in tolk 1.3.0

Collaborator

thomasdarde commented May 16, 2012

Merged into master, expect this improved header in tolk 1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment