Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle javascript and build standalone packages #34

Open
amcgee opened this issue Mar 28, 2019 · 4 comments
Open

Bundle javascript and build standalone packages #34

amcgee opened this issue Mar 28, 2019 · 4 comments
Labels

Comments

@amcgee
Copy link
Member

@amcgee amcgee commented Mar 28, 2019

This issue tracks two optimizations we'd like to implement to support easier and wider adoption of d2:

  1. Publish a single concatenated javascript file for each cli entrypoint

  2. Cross-compile stand-alone executables for various platforms (windows, mac, linux) which bundles not only the d2 cli source but also the node executable itself. See pkg

If you're interested in seeing these features implemented please add a 👍 reaction to this issue!

* Details about (1)*

Currently we rely on the package manager (yarn) to install all dependencies. This is potentially problematic if someone attempts to install with npm instead, since we include a yarn.lock file instead of a package-lock.json. This shouldn't cause harm in theory, but could lead to unpredictable behavior as installed dependency versions become non-deterministic. The solution proposed here is to bundle all sources and dependencies for each entry-point into a single javascript file. Care will have to be taken to de-duplicate common dependencies and to support npm local installations (though that's a secondary goal).

@amcgee amcgee added the enhancement label Mar 28, 2019
@stale

This comment has been minimized.

Copy link

@stale stale bot commented Jun 26, 2019

Hi! Due to a lack of activity on this issue over time (7.776*10^9 ms and counting, to be precise) it seems to be stale. If there is no further progress on it, it will be closed automatically.

If this is still relevant, maybe there is something you can do to move it forward? For example provide further information in a comment, or supply a PR? Any activity on this issue will keep it open. Thanks! 🤖

@stale stale bot added the stale label Jun 26, 2019
@amcgee

This comment has been minimized.

Copy link
Member Author

@amcgee amcgee commented Jul 17, 2019

I'd still like to do this

@stale stale bot removed the stale label Jul 17, 2019
@stale

This comment has been minimized.

Copy link

@stale stale bot commented Oct 15, 2019

Hi! Due to a lack of activity on this issue over time (7.776*10^9 ms and counting, to be precise) it seems to be stale. If there is no further progress on it, it will be closed automatically.

If this is still relevant, maybe there is something you can do to move it forward? For example provide further information in a comment, or supply a PR? Any activity on this issue will keep it open. Thanks! 🤖

@stale stale bot added the stale label Oct 15, 2019
@amcgee

This comment has been minimized.

Copy link
Member Author

@amcgee amcgee commented Oct 17, 2019

throws life-preserver

@stale stale bot removed the stale label Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.