-
Notifications
You must be signed in to change notification settings - Fork 1
Improvements on the StringLiteral Input #318
Conversation
@kilchenmann which repo and branch should I use for the review? Is knora-ui-playground with wip/viewer-resource ok? |
@flavens Oh yes I forgot to tell you in which repo I tested the component. It's wip/edit-list-nodes in Kuirl |
Is it possible to add a node in a different language? Or is it part of update and it's not implemented yet? > ok I figured out that the update is not implemented and I have to fill in the input without pressing Enter in between - otherwise the edit mode is on.. |
So, I have spotted a few things, I do not know if it was in your specifications:
|
Yes it's possible
Edit nodes is disabled by using the readonly parameter on the input field. In this case the value is visible but not editable
I also thought about this possible issue. I don't know yet.
Yes... but the "big" button and "no margin" is only visible on button hover.
|
ok! I use to press Enter once I fill in a form input, I suppose a lot of users does that. But once the field is also editable, it's no problem! |
Yes you're right. With Enter you submit the data. I thought it's more comfortable than with a mouse click. But yes, in this case you can't add a value in a different language. Hm...that's bad and I not thought about it. |
Yes I agree, it is more comfortable. But then we need the possibility to add new value in different languages, meaning update mode |
Update mode will be implemented / activated as soon Knora API is ready to do so. |
@flavens: Can you explain this again? I do not understand anymore 😉
What I did, just to explain. By creating a new list, the user starts with selecting a language for the label and adds a list label. As long the description is empty, it updates the language selector of dscription to the same as the label has. With this method, a user doesn't have to select the same language for description again (one click less). But I'm not sure if you meant this... |
Or did you mean the description in the list of lists? |
No, it is something different. When I create a new list, with a label and description, first in my default language (my user language, english for example) and then in German and French. The label and description displayed in the accordion menu are in German and not in English: |
Ah yes I understand. This is not part of this PR an has to be handled in dasch-swiss/dsp-das#75 |
ok I will create an issue in Kuirl and link it to the PR description |
@flavens I already added the comment to the existing issue. |
Thanks @flavens |
In this PR we optimized the String Literal input component from @knora/action module. And it contains a new feature: an angular pipe to stringify an array of StringLiterals:
The usage in a template as
{{labels | stringifyStringLiteral}}
becomesFrühling (de) / Spring (en) / Printemps (fr)