Support binding the Mapper to a specific window #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs #73 Rather than defaulting to whatever window is current, it selects the "current" window on init (eg: createEmpty) and uses that forever unless another window is specified. If provided a non-primary Window, that window will be cleared before the map is rendered into it. Furthermore, we simplify the resize mechanics to match *the specific window* we're rendering into.
Closes #73 This commit also renames the internal IJudoWindow.onSubmit to `onSubmitFn`. It's a little annoying, but it allows a simple implementation of onSubmit for `IScriptWindow` that doesn't conflict with `IJudoWindow`, so implementations of `IScriptWindow` can also implement `IJudoWindow` for greater interop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #73