New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show blocked elements instead if just blocked ads on icon. #1277

Open
nextgenthemes opened this Issue Nov 9, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@nextgenthemes

nextgenthemes commented Nov 9, 2017

Describe the issue

I am coming from uBlock origin and I am used to see if there are currently any blocked elements on the page. I need that when debugging sites ... The issue with AdNauseam is that it hides that original uBlock stats behind two mouse-clicks and I only now discovered this. I always thought when it shows a 0 it means no blocked elements, when in fact my privacy filters and stuff are indeed blocking elements but its not visible in the blink of an eye.

Please make it a option just to pass the blocked items to the icon counter instead if just the blocked (or clicked?) ads.

One or more specific URLs where the issue occurs

For example on this very Github page, there are actually 3 things blocked one of them is google analytics but its not visible to me until I bring up that original uBlock info window.

Screenshot in which the issue can be seen

Let me know if you need one, I think you understand.

Your settings

  • OS/version: Ubuntu 17.04
  • Browser/version: Firefox 57
  • AdNauseam version: v3.4.402
  • Other extensions you have installed: nothing relevant to this
@dhowe

This comment has been minimized.

Show comment
Hide comment
@dhowe

dhowe Nov 9, 2017

Owner

Yes, I've thought about this before, and considered adding two numbers to the badge, but decided this was two confusing. Are you suggesting a preference where you pick whether to show ads or blocks? And what about hidden elements ?

Owner

dhowe commented Nov 9, 2017

Yes, I've thought about this before, and considered adding two numbers to the badge, but decided this was two confusing. Are you suggesting a preference where you pick whether to show ads or blocks? And what about hidden elements ?

@nextgenthemes

This comment has been minimized.

Show comment
Hide comment
@nextgenthemes

nextgenthemes Nov 9, 2017

Option to show blocked elements instead would be great, but I personally am not opposed to two counters.

Newer thought about hidden elements, uBlock does only show blocked i guess? Not opposed to that either (as a option) but I was mainly just looking for what I am used to from uBlock.

nextgenthemes commented Nov 9, 2017

Option to show blocked elements instead would be great, but I personally am not opposed to two counters.

Newer thought about hidden elements, uBlock does only show blocked i guess? Not opposed to that either (as a option) but I was mainly just looking for what I am used to from uBlock.

@dhowe dhowe added the Enhancement label Nov 9, 2017

@dhowe dhowe added this to the Next Tasks milestone Nov 9, 2017

@dhowe

This comment has been minimized.

Show comment
Hide comment
@dhowe

dhowe Nov 9, 2017

Owner

Agreed -- add option toggle (under 'interface') to show blocks instead of ads, default=unchecked

Owner

dhowe commented Nov 9, 2017

Agreed -- add option toggle (under 'interface') to show blocks instead of ads, default=unchecked

cqx931 added a commit to cqx931/AdNauseam that referenced this issue Nov 13, 2017

@cqx931

This comment has been minimized.

Show comment
Hide comment
@cqx931

cqx931 Nov 13, 2017

Collaborator

Please check #1279.
For blocking requests, the badge color is red; For adnauseam ad counts, the badge color is blue.

Collaborator

cqx931 commented Nov 13, 2017

Please check #1279.
For blocking requests, the badge color is red; For adnauseam ad counts, the badge color is blue.

dhowe added a commit that referenced this issue Nov 13, 2017

@dhowe

This comment has been minimized.

Show comment
Hide comment
@dhowe

dhowe Nov 13, 2017

Owner

This was not ready for a PR: see #1281

On hold until we have an interface plan

Owner

dhowe commented Nov 13, 2017

This was not ready for a PR: see #1281

On hold until we have an interface plan

@dhowe dhowe added the On-hold label Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment