Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Bad call to _createCollection #120

Closed
sdemjanenko opened this Issue · 1 comment

2 participants

@sdemjanenko

When using the collectionType attribute for a relation the _createCollection is passed the options: {model: undefined}. The collection I linked to in collectionType already has the model set. The options then override that model and I get an error.

An ugly fix is:

data = this._createCollection(collectionType || BackboneCollection,
              relation.collectionOptions || (relatedModel ? {model: relatedModel} : {}));
@dhruvaray dhruvaray added the bug label
@dhruvaray dhruvaray self-assigned this
@dhruvaray dhruvaray referenced this issue from a commit
@dhruvaray Fix for issue #120 d0a7e0e
@dhruvaray
Owner

This should fix the problem... Let me know if it works for you.

@dhruvaray dhruvaray closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.