Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Add missing require of path module

  • Loading branch information...
commit 51c62f7666169a1f7e0e583ba724ba8825b459bf 1 parent 9921051
@aredridel aredridel authored committed
Showing with 1 addition and 0 deletions.
  1. +1 −0  src/bosh-event-emitter.js
View
1  src/bosh-event-emitter.js
@@ -27,6 +27,7 @@ var EventPipe = require('eventpipe').EventPipe;
var util = require('util');
var dutil = require('./dutil.js');
var us = require('underscore');
+var path = require('path');
@anup Collaborator
anup added a note

Why is this required? I do not see any usage of 'path' in this file.

@dhruvbird Owner

I think that the patch was provided against another branch and the pull request was against the master branch. 5b0f2d3 In the context of that diff, it makes sense. Once we merge branches, it will make sense.

@anup Collaborator
anup added a note

Which branch? Are we merging any branch? I am releasing 0.6.2 on master.

@dhruvbird Owner

No, we aren't merging any branch for this release, but when we do, it will make sense. Currently, this is like an unused line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
function BoshEventPipe(http_server) {
this.server = http_server;
@anup

Why is this required? I do not see any usage of 'path' in this file.

@dhruvbird

I think that the patch was provided against another branch and the pull request was against the master branch. 5b0f2d3 In the context of that diff, it makes sense. Once we merge branches, it will make sense.

@anup

Which branch? Are we merging any branch? I am releasing 0.6.2 on master.

@dhruvbird

No, we aren't merging any branch for this release, but when we do, it will make sense. Currently, this is like an unused line.

Please sign in to comment.
Something went wrong with that request. Please try again.