Skip to content
Browse files

Upgraded dependencies. Implemented new log4js API. Might break. Not y…

…et fully tester. Breaking on node version 0.8.x
  • Loading branch information...
1 parent a1c2203 commit d4f6a474a421109f20c01180d87110435cf8c605 @anup anup committed Aug 23, 2012
Showing with 12 additions and 14 deletions.
  1. +8 −8 package.json
  2. +3 −4 src/log.js
  3. +1 −2 src/lookup-service.js
View
16 package.json
@@ -8,20 +8,20 @@
"description": "An XMPP BOSH server written for node.js in javascript",
"author": "Dhruv Matani",
"dependencies": {
- "node-expat": "=1.4.5",
- "ltx": "= 0.0.4",
+ "node-expat": "= 1.6.1",
+ "ltx": "= 0.1.2",
"node-uuid": "= 1.3.3",
"tav": "= 0.1.0",
- "underscore": "= 1.1.5",
+ "underscore": "= 1.3.3",
"eventpipe": "= 0.0.5",
"dns-srv": "= 0.0.6",
"semver": "= 1.0.8",
- "ws": "= 0.4.12",
- "log4js": "= 0.4.2"
+ "ws": "= 0.4.19",
+ "log4js": "= 0.5.2"
},
"devDependencies": {
- "jsdom": "= 0.2.0",
- "jslint": "= 0.1.2"
+ "jsdom": "= 0.2.15",
+ "jslint": "= 0.1.9"
},
"repositories": [
{
@@ -74,6 +74,6 @@
}
],
"engines": {
- "node": ">=0.4.1"
+ "node": ">=0.6.19"
}
}
View
7 src/log.js
@@ -1,12 +1,11 @@
var log4js = require("log4js");
log4js.configure({
- doNotReplaceConsole: true
+ appenders:[
+ { type:"console" }
+ ]
});
-var appender = log4js.consoleAppender(log4js.basicLayout);
-log4js.clearAppenders();
-log4js.addAppender(appender);
log4js.setGlobalLogLevel("INFO");
var set_log_level = function (level) {
View
3 src/lookup-service.js
@@ -26,7 +26,6 @@
var util = require('util');
var SRV = require('dns-srv');
var dutil = require('./dutil.js');
-var us = require('underscore');
var events = require('events');
var path = require('path');
@@ -103,7 +102,7 @@ dutil.copy(XMPPLookupService.prototype, {
}
function try_connect_SRV_lookup() {
- log.trace('try_connect_SRV_lookup - %s',self._domain_name);
+ log.trace('try_connect_SRV_lookup - %s, %s',self._domain_name, self._port);
// Then try a normal SRV lookup.

3 comments on commit d4f6a47

@dhruvbird
Owner

Isn't the port fetched from the srv lookup itself?

@anup
Collaborator
anup commented on d4f6a47 Aug 26, 2012

Yes. I am just trying to log what we pass as a default port in the function SRV.connect(). This was not logged.

@dhruvbird
Owner

Okay. Is there some way you can make it clear that this is just a default and not something that will be used - might be confusing while debugging.

Please sign in to comment.
Something went wrong with that request. Please try again.