Permalink
Browse files

Revert "Enabled replacement of node's console.log"

This reverts commit 49299f9.
  • Loading branch information...
1 parent c523e9a commit ed888fed704be1cdc5f615ad29ad5b8d00e3174f @anup anup committed Sep 11, 2012
Showing with 1 addition and 2 deletions.
  1. +1 −2 src/log.js
View
@@ -3,8 +3,7 @@ var log4js = require("log4js");
log4js.configure({
appenders:[
{ type:"console" }
- ],
- replaceConsole: true
+ ]
});
log4js.setGlobalLogLevel("INFO");

4 comments on commit ed888fe

Owner

dhruvbird replied Sep 14, 2012

@anup I am still seeing some log4js ugliness.

[2012-09-14 16:51:58.779] [INFO] console - +-----------------------------------------------------------------------------------------------------------------+
[2012-09-14 16:51:58.780] [INFO] console - | Starting BOSH server 'v0.6.3' on 'http://0.0.0.0:10280/http-bind/' at 'Fri Sep 14 2012 16:51:58 GMT-0400 (EDT)' |
[2012-09-14 16:51:58.781] [INFO] console - +-----------------------------------------------------------------------------------------------------------------+
[2012-09-14 16:51:58.783] [INFO] console - +--------------------------------------------------------------------------------------------------------+
[2012-09-14 16:51:58.783] [INFO] console - | Starting WEBSOCKET server 'v0.6.3' on ws://0.0.0.0:10280' at 'Fri Sep 14 2012 16:51:58 GMT-0400 (EDT)' |
[2012-09-14 16:51:58.783] [INFO] console - +--------------------------------------------------------------------------------------------------------+

Do you think it's time to merge node-lumberjack-logger into master?

Collaborator

anup replied Sep 17, 2012

Not sure what is ugly? And I am yet to evaluate the performance of node-lumberjack-logger. Any leads on that?

Owner

dhruvbird replied Sep 17, 2012

@anup We're using console.log to print these message and not log.info() right? So, the part "[2012-09-14 16:51:58.783] [INFO] console " should not show up - especially since that is disabled in log4js' config.

Owner

dhruvbird replied Sep 17, 2012

@anup w.r.t node-lumberjack, do you want to do production testing or synthetic benchmarking?

Please sign in to comment.